Propagate SetDecoderHeaderTableDebugVisitor to the nested SpdyFramerDecoderAdapter.

Propagate SetDecoderHeaderTableDebugVisitor to the nested SpdyFramerDecoderAdapter.

Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor to the nested SpdyFramerDecoderAdapter, if present. This fixes several test failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
Committed: https://crrev.com/38cb11390a316057b1990c5257a9379d6807da84
Cr-Commit-Position: refs/heads/master@{#404590}

[yinjie, 2016-07-08 01:08:12]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 01:09:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 02:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 02:14:40]

Dry run: This issue passed the CQ dry run.

[yinjie, 2016-07-08 16:27:01]

The CQ bit was checked by yinjie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 16:27:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 16:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 16:33:03]

Dry run: This issue passed the CQ dry run.

[yinjie, 2016-07-08 16:37:59]

yinjie@chromium.org changed reviewers:
+ bnc@chromium.org

[Bence, 2016-07-08 20:21:56]

Please add a short title to the CL, preferably at most 80 characters.

Please remove reference to spdy_deframer_visitor_test in CL description, as this
file does not exist in Chromium.

[yinjie, 2016-07-08 22:32:23]

Description was changed from

==========
Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, such as in spdy_deframer_visitor_test, if
--use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
==========

to

==========
Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
==========

[yinjie, 2016-07-08 22:32:47]

On 2016/07/08 20:21:56, Bence wrote:
> Please add a short title to the CL, preferably at most 80 characters.
> 
> Please remove reference to spdy_deframer_visitor_test in CL description, as
this
> file does not exist in Chromium.

Thanks for the comment. Please take a look. Thanks!

[yinjie, 2016-07-08 22:32:52]

On 2016/07/08 20:21:56, Bence wrote:
> Please add a short title to the CL, preferably at most 80 characters.
> 
> Please remove reference to spdy_deframer_visitor_test in CL description, as
this
> file does not exist in Chromium.

Thanks for the comment. Please take a look. Thanks!

[Bence, 2016-07-09 14:05:38]

Description was changed from

==========
Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
==========

to

==========
Propagate SetDecoderHeaderTableDebugVisitor to the nested
SpdyFramerDecoderAdapter.

Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
==========

[Bence, 2016-07-09 14:10:59]

LGTM.

I forgot to tell you, Rietveld does something counterintuitive: in "Edit Issue",
you can change the Subject and the Description separately, and they show up
properly on the web interface.  However, when landing a change, the Subject is
ignored, and the Description becomes the commit message.  So when changing the
Subject, you also need to change the first line of the Description to match it,
followed by a blank line.  I know, it is confusing.

I just edited this CL description for you accordingly, you can commit now when
you're ready.

[yinjie1, 2016-07-10 21:23:09]

On 2016/07/09 14:10:59, Bence wrote:
> LGTM.
> 
> I forgot to tell you, Rietveld does something counterintuitive: in "Edit
Issue",
> you can change the Subject and the Description separately, and they show up
> properly on the web interface.  However, when landing a change, the Subject is
> ignored, and the Description becomes the commit message.  So when changing the
> Subject, you also need to change the first line of the Description to match
it,
> followed by a blank line.  I know, it is confusing.
> 
> I just edited this CL description for you accordingly, you can commit now when
> you're ready.

Thanks for letting me know and correcting the CL description for me.

[yinjie1, 2016-07-10 21:23:15]

The CQ bit was checked by yinjie@google.com

[commit-bot: I haz the power, 2016-07-10 21:23:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-10 23:00:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-10 23:00:42]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yinjie1, 2016-07-10 23:45:18]

The CQ bit was checked by yinjie@google.com

[commit-bot: I haz the power, 2016-07-10 23:45:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 01:35:32]

Description was changed from

==========
Propagate SetDecoderHeaderTableDebugVisitor to the nested
SpdyFramerDecoderAdapter.

Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
==========

to

==========
Propagate SetDecoderHeaderTableDebugVisitor to the nested
SpdyFramerDecoderAdapter.

Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
==========

[commit-bot: I haz the power, 2016-07-11 01:35:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-11 01:37:38]

Description was changed from

==========
Propagate SetDecoderHeaderTableDebugVisitor to the nested
SpdyFramerDecoderAdapter.

Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484
==========

to

==========
Propagate SetDecoderHeaderTableDebugVisitor to the nested
SpdyFramerDecoderAdapter.

Propagate force_use_new_methods_for_test and SetDecoderHeaderTableDebugVisitor
to the nested SpdyFramerDecoderAdapter, if present. This fixes several test
failures, if --use_nested_spdy_framer_decoder=true.

This CL lands server change 126441874 by jamessynge.

BUG=488484

Committed: https://crrev.com/38cb11390a316057b1990c5257a9379d6807da84
Cr-Commit-Position: refs/heads/master@{#404590}
==========

[commit-bot: I haz the power, 2016-07-11 01:37:38]

Patchset 1 (id:??) landed as
https://crrev.com/38cb11390a316057b1990c5257a9379d6807da84
Cr-Commit-Position: refs/heads/master@{#404590}