Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2130173002: Add metrics for app banner preventDefault() and prompt(). (Closed)

Created:
4 years, 5 months ago by dominickn
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add metrics for app banner preventDefault() and prompt(). The beforeinstallprompt event signals an imminent app install banner for a page. This CL adds UMA stats for preventDefault() being called on the event (stopping the banner from appearing), and for prompt() being called on the event (making the banner appear subsequent to a preventDefault()). BUG=625716 Review-Url: https://codereview.chromium.org/2122783002 Cr-Commit-Position: refs/heads/master@{#404039} (cherry picked from commit 4f6382c45e105322038b6fa1885cd1f479ef5ff8) Committed: https://chromium.googlesource.com/chromium/src/+/b533085ebf0bb4148b47ec27faf62e1619a4c5f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher.cc View 6 chunks +21 lines, -1 line 0 comments Download
M chrome/browser/banners/app_banner_metrics.h View 5 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/banners/app_banner_metrics.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
4 years, 5 months ago (2016-07-08 00:48:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b533085ebf0bb4148b47ec27faf62e1619a4c5f1.

Powered by Google App Engine
This is Rietveld 408576698