Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2130163002: MD History: Fix focus highlight on history item text (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix focus highlight on history item text In crrev.com/403847, a line was removed from history-item's CSS which did not appear to have any impact on the page. However, this was necessary for displaying the focus highlight around the item title correctly. This CL restores the removed line. BUG=626260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a9d391f96b194ec3142279f1cd9755c7470462b0 Cr-Commit-Position: refs/heads/master@{#404312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/md_history/history_item.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130163002/1
4 years, 5 months ago (2016-07-08 00:41:44 UTC) #3
tsergeant
PTAL, just a one-line change.
4 years, 5 months ago (2016-07-08 00:42:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-08 01:19:59 UTC) #7
calamity
weird. lgtm.
4 years, 5 months ago (2016-07-08 01:46:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130163002/1
4 years, 5 months ago (2016-07-08 02:24:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 02:28:31 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 02:28:45 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 02:29:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9d391f96b194ec3142279f1cd9755c7470462b0
Cr-Commit-Position: refs/heads/master@{#404312}

Powered by Google App Engine
This is Rietveld 408576698