Clean up max_frame_size related constants, move storage of setting to the framer.

net/spdy/spdy_frame_builder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_frame_builder.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "net/spdy/spdy_bug_tracker.h"
@@ skipping 91 matching lines @@
                                      uint8_t flags,
                                      SpdyStreamId stream_id) {
   DCHECK(SpdyConstants::IsValidFrameType(
       version_, SpdyConstants::SerializeFrameType(version_, type)));
   DCHECK_EQ(0u, stream_id & ~kStreamIdMask);
   DCHECK_EQ(HTTP2, framer.protocol_version());
   bool success = true;
   if (length_ > 0) {
     // Update length field for previous frame.
     OverwriteLength(framer, length_ - framer.GetPrefixLength(type));
-    SPDY_BUG_IF(SpdyConstants::GetFrameMaximumSize(version_) < length_)
+    SPDY_BUG_IF(framer.GetFrameMaximumSize() < length_)
         << "Frame length  " << length_
         << " is longer than the maximum allowed length.";
   }
 
   offset_ += length_;
   length_ = 0;
 
   // Assume all remaining capacity will be used for this frame. If not,
   // the length will get overwritten when we begin the next frame.
   // Don't check for length limits here because this may be larger than the
@@ skipping 40 matching lines @@
 }
 
 bool SpdyFrameBuilder::RewriteLength(const SpdyFramer& framer) {
   return OverwriteLength(framer,
                          length_ - framer.GetControlFrameHeaderSize());
 }
 
 bool SpdyFrameBuilder::OverwriteLength(const SpdyFramer& framer,
                                        size_t length) {
   if (version_ == SPDY3) {
-    DCHECK_LE(length,
-              SpdyConstants::GetFrameMaximumSize(version_) -
-                  framer.GetFrameMinimumSize());
+    DCHECK_GE(framer.GetFrameMaximumSize() - framer.GetFrameMinimumSize(),
+              length);
   } else {
-    DCHECK_LE(length, SpdyConstants::GetFrameMaximumSize(version_));
+    DCHECK_GE(framer.GetFrameMaximumSize(), length);
   }
   bool success = false;
   const size_t old_length = length_;
 
   if (version_ == SPDY3) {
     FlagsAndLength flags_length = CreateFlagsAndLength(
         0,  // We're not writing over the flags value anyway.
         length);
 
     // Write into the correct location by temporarily faking the offset.
@@ skipping 28 matching lines @@
 
   if (offset_ + length_ + length > capacity_) {
     DCHECK(false);
     return false;
   }
 
   return true;
 }
 
 }  // namespace net