Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2130133004: Tracking text selection on the browser side in OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initialize/Clear TextSelection for each view + make GetTextSelection() const. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 8256e7e8c10fee99ca34caf3e469c5bbc351e359..56469f056cde1fad9ef325091ab76f4c4c38616c 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -4477,4 +4477,66 @@ TEST_F(InputMethodStateAuraTest, GetCompositionCharacterBounds) {
}
}
+// This test is for selected text.
+TEST_F(InputMethodStateAuraTest, GetSelectedText) {
+ base::string16 text = base::ASCIIToUTF16("some text of length 22");
+ size_t offset = 0U;
+ gfx::Range selection_range(20, 21);
+
+ for (auto index : active_view_sequence_) {
+ ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
+ views_[index]->SelectionChanged(text, offset, selection_range);
+ base::string16 expected_text = text.substr(
+ selection_range.GetMin() - offset, selection_range.length());
+
+ EXPECT_EQ(expected_text, views_[index]->GetSelectedText());
+
+ // Changing offset to make sure that the next view has a different text
+ // selection.
+ offset++;
+ }
+}
+
+// This test is for text range.
+TEST_F(InputMethodStateAuraTest, GetTextRange) {
+ base::string16 text = base::ASCIIToUTF16("some text of length 22");
+ size_t offset = 0U;
+ gfx::Range selection_range;
+
+ for (auto index : active_view_sequence_) {
+ ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
+ gfx::Range expected_range(offset, offset + text.length());
+ views_[index]->SelectionChanged(text, offset, selection_range);
+ gfx::Range range_from_client;
+
+ // For aura this always returns true.
+ EXPECT_TRUE(text_input_client()->GetTextRange(&range_from_client));
+ EXPECT_EQ(expected_range, range_from_client);
+
+ // Changing offset to make sure that the next view has a different text
+ // selection.
+ offset++;
+ }
+}
+
+// This test is for selection range.
+TEST_F(InputMethodStateAuraTest, GetSelectionRange) {
+ base::string16 text;
+ gfx::Range expected_range(0U, 1U);
+
+ for (auto index : active_view_sequence_) {
+ ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
+ views_[index]->SelectionChanged(text, 0U, expected_range);
+ gfx::Range range_from_client;
+
+ // This method always returns true.
+ EXPECT_TRUE(text_input_client()->GetSelectionRange(&range_from_client));
+ EXPECT_EQ(expected_range, range_from_client);
+
+ // Changing range to make sure that the next view has a different text
+ // selection.
+ expected_range.set_end(expected_range.end() + 1U);
+ }
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698