content/browser/frame_host/render_widget_host_view_child_frame.h - Issue 2130133004: Tracking text selection on the browser side in OOPIF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 2130133004: Tracking text selection on the browser side in OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initialize/Clear TextSelection for each view + make GetTextSelection() const. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('k') | content/browser/frame_host/render_widget_host_view_child_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.h

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.h b/content/browser/frame_host/render_widget_host_view_child_frame.h

index 781c2cff92cfad25252c04641233bf2eee9cb556..ebffef69dc27e71737b48bc4bc6dcfbe96f16c90 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.h

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.h

@@ -99,9 +99,6 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame

int error_code) override;

void Destroy() override;

void SetTooltipText(const base::string16& tooltip_text) override;

- void SelectionChanged(const base::string16& text,

- size_t offset,

- const gfx::Range& range) override;

void CopyFromCompositingSurface(

const gfx::Rect& src_subrect,

const gfx::Size& dst_size,