Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2130133004: Tracking text selection on the browser side in OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_base.h
diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h
index 0a1e01ebc6587bb1cb833e6101e5325d1b13fbf0..5145e90fc809d3c1954a367f56e0521dd761a840 100644
--- a/content/browser/renderer_host/render_widget_host_view_base.h
+++ b/content/browser/renderer_host/render_widget_host_view_base.h
@@ -432,6 +432,11 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// Whether we are showing a context menu.
bool showing_context_menu_;
+// TODO(ekaramad): In aura, text selection tracking for IME is done through the
+// TextInputManager. We still need the following variables for other platforms.
+// Remove them when tracking is done by TextInputManager on all platforms
+// (https://crbug.com/578168 and https://crbug.com/602427).
+#if !defined(USE_AURA)
// A buffer containing the text inside and around the current selection range.
base::string16 selection_text_;
@@ -441,6 +446,7 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
// The current selection range relative to the start of the web page.
gfx::Range selection_range_;
+#endif
// The scale factor of the display the renderer is currently on.
float current_device_scale_factor_;

Powered by Google App Engine
This is Rietveld 408576698