Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/standalone/javascript_int_overflow_literal_test.dart

Issue 21301003: Fixes javascript integer overflow check. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/object.cc ('K') | « tests/standalone/53bit_overflow_test.dart ('k') | tests/standalone/javascript_int_overflow_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/javascript_int_overflow_literal_test.dart
===================================================================
--- tests/standalone/javascript_int_overflow_literal_test.dart (revision 25633)
+++ tests/standalone/javascript_int_overflow_literal_test.dart (working copy)
@@ -8,11 +8,11 @@
import "package:expect/expect.dart";
int literals() {
- var okay_literal = 0xFFFFFFFFFFFFF;
- var too_big_literal = 0x1FFFFFFFFFFFFF; /// 01: compile-time error
+ var okay_literal = 0x1FFFFFFFFFFFFF;
+ var too_big_literal = 0x20000000000000; /// 01: compile-time error
Florian Schneider 2013/08/02 10:24:17 0x20000000000000 is fine. 0x20000000000001 too la
return okay_literal;
}
main() {
- Expect.equals(0xFFFFFFFFFFFFF, literals());
+ Expect.equals(0x1FFFFFFFFFFFFF, literals());
}
« runtime/vm/object.cc ('K') | « tests/standalone/53bit_overflow_test.dart ('k') | tests/standalone/javascript_int_overflow_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698