Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2998)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/parser.cc

Issue 21301003: Fixes javascript integer overflow check. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | runtime/vm/symbols.h » ('j') | tests/standalone/javascript_int_overflow_literal_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 25633)
+++ runtime/vm/parser.cc (working copy)
@@ -378,9 +378,10 @@
RawInteger* ri = Integer::RawCast(literal_token_.value());
if (FLAG_throw_on_javascript_int_overflow) {
const Integer& i = Integer::Handle(ri);
- if (i.CheckFiftyThreeBitOverflow()) {
- ErrorMsg(TokenPos(), "Integer literal does not fit in 53 bits: %s.",
- i.ToCString());
+ if (i.CheckJavascriptIntegerOverflow()) {
+ ErrorMsg(TokenPos(),
+ "Integer literal does not fit in a Javascript integer: %s.",
+ i.ToCString());
}
}
return ri;
« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | runtime/vm/symbols.h » ('j') | tests/standalone/javascript_int_overflow_literal_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698