Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/errors_patch.dart

Issue 21301003: Fixes javascript integer overflow check. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/exceptions.h » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/errors_patch.dart
===================================================================
--- runtime/lib/errors_patch.dart (revision 25633)
+++ runtime/lib/errors_patch.dart (working copy)
@@ -178,9 +178,9 @@
}
}
-class _FiftyThreeBitOverflowError extends Error {
+class _FiftyFourBitOverflowError extends Error {
final Object _value;
- _FiftyThreeBitOverflowError(this._value);
- String toString() => "53-bit Overflow: $_value";
+ _FiftyFourBitOverflowError(this._value);
+ String toString() => "54-bit Overflow: $_value";
siva 2013/07/31 16:08:28 Should the string say "Javascript Integer Overflow
zra 2013/07/31 17:46:31 Done.
}
« no previous file with comments | « no previous file | runtime/vm/exceptions.h » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698