Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2130053002: cc: Clean up Layer and LayerTreeHost. (Closed)

Created:
4 years, 5 months ago by khushalsagar
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO), Khushal
CC:
ajuma, cc-bugs_chromium.org, chromium-reviews, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@start_minor_layer_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clean up Layer and LayerTreeHost. Remove public methods from Layer and LayerTreeHost that are just a pass through to the AnimationHost. These are used by the PropertyTreeBuilder, have it query the AnimationHost directly. BUG=625384 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/af222d99793df4ab3b2cffc09535d623584863b3 Cr-Commit-Position: refs/heads/master@{#404492}

Patch Set 1 #

Patch Set 2 : Remove unused methods from impl side. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -373 lines) Patch
M cc/layers/layer.h View 1 2 9 chunks +17 lines, -23 lines 0 comments Download
M cc/layers/layer.cc View 1 2 7 chunks +27 lines, -56 lines 0 comments Download
M cc/layers/layer_impl.h View 1 6 chunks +12 lines, -11 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 6 chunks +30 lines, -33 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +0 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 1 chunk +0 lines, -27 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 1 chunk +0 lines, -116 lines 0 comments Download
M cc/trees/property_tree.cc View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 2 9 chunks +69 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Khushal
4 years, 5 months ago (2016-07-07 21:07:34 UTC) #3
enne (OOO)
This looks reasonable to me. Can you remove similar unused methods from LayerImpl as well?
4 years, 5 months ago (2016-07-07 21:47:51 UTC) #4
Khushal
On 2016/07/07 21:47:51, enne wrote: > This looks reasonable to me. Can you remove similar ...
4 years, 5 months ago (2016-07-07 22:52:16 UTC) #5
Khushal
On 2016/07/07 22:52:16, Khushal wrote: > On 2016/07/07 21:47:51, enne wrote: > > This looks ...
4 years, 5 months ago (2016-07-08 18:05:29 UTC) #6
enne (OOO)
lgtm
4 years, 5 months ago (2016-07-08 18:30:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130053002/20001
4 years, 5 months ago (2016-07-08 18:49:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/32925) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-08 18:51:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130053002/40001
4 years, 5 months ago (2016-07-08 19:26:18 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 21:19:50 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 21:20:04 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:22:14 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/af222d99793df4ab3b2cffc09535d623584863b3
Cr-Commit-Position: refs/heads/master@{#404492}

Powered by Google App Engine
This is Rietveld 408576698