Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: sync/api/sync_data_unittest.cc

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi
Patch Set: Apply feedback from review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/api/sync_data.cc ('k') | sync/sync_api.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/sync_data_unittest.cc
diff --git a/sync/api/sync_data_unittest.cc b/sync/api/sync_data_unittest.cc
index 7ca39bf2218942f4c1b6d0d2f9e43e2e6d5f3534..4eab286a95a06de736d487c1d25f1e887e8e538b 100644
--- a/sync/api/sync_data_unittest.cc
+++ b/sync/api/sync_data_unittest.cc
@@ -120,16 +120,6 @@ TEST_F(SyncDataTest, CreateRemoteData) {
EXPECT_TRUE(data.GetAttachmentIds().empty());
}
-TEST_F(SyncDataTest, CreateRemoteData_WithoutAttachmentService) {
- specifics.mutable_preference();
- SyncData data = SyncData::CreateRemoteData(kId, specifics, kLastModifiedTime);
- EXPECT_TRUE(data.IsValid());
- EXPECT_FALSE(data.IsLocal());
- EXPECT_EQ(kId, SyncDataRemote(data).GetId());
- EXPECT_EQ(kLastModifiedTime, SyncDataRemote(data).GetModifiedTime());
- EXPECT_TRUE(data.GetSpecifics().has_preference());
-}
-
// TODO(maniscalco): Add test cases that verify GetLocalAttachmentsForUpload and
// DropAttachments calls are passed through to the underlying AttachmentService.
« no previous file with comments | « sync/api/sync_data.cc ('k') | sync/sync_api.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698