chrome/browser/sync/glue/generic_change_processor.cc - Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/generic_change_processor.cc

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi

Patch Set: Apply feedback from review Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/favicon_cache_unittest.cc ('k') | chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/generic_change_processor.cc

diff --git a/chrome/browser/sync/glue/generic_change_processor.cc b/chrome/browser/sync/glue/generic_change_processor.cc

index f90365d9fb8bd7132b13c78a60d412d861030c23..a21263ffdd0330b734d572a328358e621d698227 100644

--- a/chrome/browser/sync/glue/generic_change_processor.cc

+++ b/chrome/browser/sync/glue/generic_change_processor.cc

@@ -78,9 +78,9 @@ GenericChangeProcessor::GenericChangeProcessor(

share_handle_(user_share),

attachment_service_(attachment_service.Pass()),

attachment_service_weak_ptr_factory_(attachment_service_.get()),

- attachment_service_proxy_(syncer::AttachmentServiceProxy(

+ attachment_service_proxy_(

base::MessageLoopProxy::current(),

- attachment_service_weak_ptr_factory_.GetWeakPtr())) {

+ attachment_service_weak_ptr_factory_.GetWeakPtr()) {

DCHECK(CalledOnValidThread());

DCHECK(attachment_service_);

}