Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5089)

Unified Diff: chrome/browser/history/history_unittest.cc

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi
Patch Set: Apply feedback from review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_unittest.cc
diff --git a/chrome/browser/history/history_unittest.cc b/chrome/browser/history/history_unittest.cc
index 7b84822e9a841bd343a054fce5f1d4f552f65a55..8bb8361bd3d3cb0c457f0a11258abb511f5876e9 100644
--- a/chrome/browser/history/history_unittest.cc
+++ b/chrome/browser/history/history_unittest.cc
@@ -60,6 +60,8 @@
#include "content/public/browser/notification_source.h"
#include "sql/connection.h"
#include "sql/statement.h"
+#include "sync/api/attachments/attachment_id.h"
+#include "sync/api/attachments/attachment_service_proxy_for_test.h"
#include "sync/api/fake_sync_change_processor.h"
#include "sync/api/sync_change.h"
#include "sync/api/sync_change_processor.h"
@@ -1633,8 +1635,12 @@ TEST_F(HistoryTest, ProcessGlobalIdDeleteDirective) {
.ToInternalValue());
global_id_directive->set_start_time_usec(3);
global_id_directive->set_end_time_usec(10);
- directives.push_back(
- syncer::SyncData::CreateRemoteData(1, entity_specs, base::Time()));
+ directives.push_back(syncer::SyncData::CreateRemoteData(
+ 1,
+ entity_specs,
+ base::Time(),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest::Create()));
// 2nd directive.
global_id_directive->Clear();
@@ -1643,8 +1649,12 @@ TEST_F(HistoryTest, ProcessGlobalIdDeleteDirective) {
.ToInternalValue());
global_id_directive->set_start_time_usec(13);
global_id_directive->set_end_time_usec(19);
- directives.push_back(
- syncer::SyncData::CreateRemoteData(2, entity_specs, base::Time()));
+ directives.push_back(syncer::SyncData::CreateRemoteData(
+ 2,
+ entity_specs,
+ base::Time(),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest::Create()));
syncer::FakeSyncChangeProcessor change_processor;
EXPECT_FALSE(
@@ -1713,17 +1723,23 @@ TEST_F(HistoryTest, ProcessTimeRangeDeleteDirective) {
->mutable_time_range_directive();
time_range_directive->set_start_time_usec(2);
time_range_directive->set_end_time_usec(5);
- directives.push_back(syncer::SyncData::CreateRemoteData(1,
- entity_specs,
- base::Time()));
+ directives.push_back(syncer::SyncData::CreateRemoteData(
+ 1,
+ entity_specs,
+ base::Time(),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest::Create()));
// 2nd directive.
time_range_directive->Clear();
time_range_directive->set_start_time_usec(8);
time_range_directive->set_end_time_usec(10);
- directives.push_back(syncer::SyncData::CreateRemoteData(2,
- entity_specs,
- base::Time()));
+ directives.push_back(syncer::SyncData::CreateRemoteData(
+ 2,
+ entity_specs,
+ base::Time(),
+ syncer::AttachmentIdList(),
+ syncer::AttachmentServiceProxyForTest::Create()));
syncer::FakeSyncChangeProcessor change_processor;
EXPECT_FALSE(

Powered by Google App Engine
This is Rietveld 408576698