sync/api/attachments/attachment_service_proxy_unittest.cc - Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment_service_proxy_unittest.cc

Issue 213003004: Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi

Patch Set: Forgot a class keyword. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/api/attachments/attachment_service_proxy_for_test.h ('K') | « sync/api/attachments/attachment_service_proxy_for_test.cc ('k') | sync/api/sync_change_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/api/attachments/attachment_service_proxy_unittest.cc

diff --git a/sync/api/attachments/attachment_service_proxy_unittest.cc b/sync/api/attachments/attachment_service_proxy_unittest.cc

index eed5e6b872928b03d64af27331e0b9bcde6e6503..d5fa30e97f0cc7e4d20e8a5c7123381de51ec1b6 100644

--- a/sync/api/attachments/attachment_service_proxy_unittest.cc

+++ b/sync/api/attachments/attachment_service_proxy_unittest.cc

@@ -104,8 +104,8 @@ class AttachmentServiceProxyTest : public testing::Test,

stub_thread.reset(new base::Thread("attachment service stub thread"));

stub_thread->Start();

stub.reset(new StubAttachmentService);

- proxy.reset(new AttachmentServiceProxy(stub_thread->message_loop_proxy(),

- stub->AsWeakPtr()));

+ proxy = new AttachmentServiceProxy(stub_thread->message_loop_proxy(),

+ stub->AsWeakPtr());

sync_data =

SyncData::CreateLocalData("tag", "title", sync_pb::EntitySpecifics());

@@ -156,7 +156,7 @@ class AttachmentServiceProxyTest : public testing::Test,

base::MessageLoop loop;

scoped_ptr<base::Thread> stub_thread;

scoped_ptr<StubAttachmentService> stub;

- scoped_ptr<AttachmentServiceProxy> proxy;

+ scoped_refptr<AttachmentServiceProxy> proxy;

SyncData sync_data;

SyncData sync_data_delete;