Replace calls to 3-arg SyncData::CreateLocalData with 5-arg version.

sync/api/sync_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/api/sync_data.h"
 
 #include <ostream>
 
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 47 matching lines @@
   return *wrapper;
 }
 
 void SyncData::ImmutableSyncEntityTraits::Swap(sync_pb::SyncEntity* t1,
                                                sync_pb::SyncEntity* t2) {
   t1->Swap(t2);
 }
 
 SyncData::SyncData() : id_(kInvalidId), is_valid_(false) {}
 
-SyncData::SyncData(int64 id,
-                   sync_pb::SyncEntity* entity,
-                   AttachmentList* attachments,
-                   const base::Time& remote_modification_time,
-                   const syncer::AttachmentServiceProxy& attachment_service)
+SyncData::SyncData(
+    int64 id,
+    sync_pb::SyncEntity* entity,
+    AttachmentList* attachments,
+    const base::Time& remote_modification_time,
+    const scoped_refptr<syncer::AttachmentServiceProxy>& attachment_service)
     : id_(id),
       remote_modification_time_(remote_modification_time),
       immutable_entity_(entity),
       attachments_(attachments),
       attachment_service_(attachment_service),
-      is_valid_(true) {}
+      is_valid_(true) {
+  DCHECK(attachment_service_);
+}
 
 SyncData::~SyncData() {}
 
 // Static.
 SyncData SyncData::CreateLocalDelete(const std::string& sync_tag,
                                      ModelType datatype) {
   sync_pb::EntitySpecifics specifics;
   AddDefaultFieldValue(datatype, &specifics);
   return CreateLocalData(sync_tag, std::string(), specifics);
 }
@@ skipping 21 matching lines @@
   entity.set_non_unique_name(non_unique_title);
   entity.mutable_specifics()->CopyFrom(specifics);
   std::transform(attachments.begin(),
                  attachments.end(),
                  RepeatedFieldBackInserter(entity.mutable_attachment_id()),
                  AttachmentToProto);
   // TODO(maniscalco): Actually pass the attachments to the ctor and make them
   // available to the AttachmentService once this SyncData gets passed into
   // GenericChangeProcesso::ProcessSyncChanges (bug 354530).
   AttachmentList copy_of_attachments(attachments);
-  return SyncData(kInvalidId,
-                  &entity,
-                  &copy_of_attachments,
-                  base::Time(),
-                  AttachmentServiceProxy());
+  scoped_refptr<AttachmentServiceProxy> proxy(new AttachmentServiceProxy);
+  return SyncData(
+      kInvalidId, &entity, &copy_of_attachments, base::Time(), proxy);
 }
 
 // Static.
 SyncData SyncData::CreateRemoteData(
     int64 id,
     const sync_pb::EntitySpecifics& specifics,
     const base::Time& modification_time,
     const AttachmentIdList& attachment_ids,
-    const AttachmentServiceProxy& attachment_service) {
+    const scoped_refptr<AttachmentServiceProxy>& attachment_service) {
   DCHECK_NE(id, kInvalidId);
   sync_pb::SyncEntity entity;
   entity.mutable_specifics()->CopyFrom(specifics);
   std::transform(attachment_ids.begin(),
                  attachment_ids.end(),
                  RepeatedFieldBackInserter(entity.mutable_attachment_id()),
                  IdToProto);
   AttachmentList attachments;
   return SyncData(
       id, &entity, &attachments, modification_time, attachment_service);
 }
 
-// Static.
-SyncData SyncData::CreateRemoteData(int64 id,
-                                    const sync_pb::EntitySpecifics& specifics,
-                                    const base::Time& modification_time) {
-  return CreateRemoteData(id,
-                          specifics,
-                          modification_time,
-                          AttachmentIdList(),
-                          AttachmentServiceProxy());
-}
-
 bool SyncData::IsValid() const { return is_valid_; }
 
 const sync_pb::EntitySpecifics& SyncData::GetSpecifics() const {
   return immutable_entity_.Get().specifics();
 }
 
 ModelType SyncData::GetDataType() const {
   return GetModelTypeFromSpecifics(GetSpecifics());
 }
 
@@ skipping 68 matching lines @@
   return remote_modification_time_;
 }
 
 int64 SyncDataRemote::GetId() const {
   return id_;
 }
 
 void SyncDataRemote::GetOrDownloadAttachments(
     const AttachmentIdList& attachment_ids,
     const AttachmentService::GetOrDownloadCallback& callback) {
-  attachment_service_.GetOrDownloadAttachments(attachment_ids, callback);
+  attachment_service_->GetOrDownloadAttachments(attachment_ids, callback);
 }
 
 void SyncDataRemote::DropAttachments(
     const AttachmentIdList& attachment_ids,
     const AttachmentService::DropCallback& callback) {
-  attachment_service_.DropAttachments(attachment_ids, callback);
+  attachment_service_->DropAttachments(attachment_ids, callback);
 }
 
 }  // namespace syncer