MD Settings: Reset page, fix dialog test that was erroneously passing.

MD Settings: Reset page, fix dialog test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Resolved by changing tests to not run in parallel, and fixing test code to
properly test closing using the 'Esc' key.

This bug was revealed while investigating migration to native <dialog>.

BUG=625332
Committed: https://crrev.com/0df9bed02b720adb4c2be76dd8254b9ae3861906
Cr-Commit-Position: refs/heads/master@{#404276}

[dpapad, 2016-07-07 19:30:48]

Description was changed from

==========
MD Settings: Reset page tests, fix test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Changing tests to not run in parallel, and fixing test code to properly test
closing using the 'Esc' key.

This bug was revealed while migrating to native <dialog>.

BUG=625332
==========

to

==========
MD Settings: Reset page tests, fix test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Resolved by changing tests to not run in parallel, and fixing test code to
properly test closing using the 'Esc' key.

This bug was revealed while investigating migration to native <dialog>.

BUG=625332
==========

[dpapad, 2016-07-07 19:31:07]

Description was changed from

==========
MD Settings: Reset page tests, fix test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Resolved by changing tests to not run in parallel, and fixing test code to
properly test closing using the 'Esc' key.

This bug was revealed while investigating migration to native <dialog>.

BUG=625332
==========

to

==========
MD Settings: Reset page, fix dialog test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Resolved by changing tests to not run in parallel, and fixing test code to
properly test closing using the 'Esc' key.

This bug was revealed while investigating migration to native <dialog>.

BUG=625332
==========

[dpapad, 2016-07-07 19:36:35]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-07 21:13:55]

i have no idea what this code does but it lgtm!

[dpapad, 2016-07-07 21:39:26]

On 2016/07/07 at 21:13:55, dbeam wrote:
> i have no idea what this code does but it lgtm!

Thanks. I tried to explain a bit in the description without being too verbose.
If you want more detail, see [1] where addOverlay() is called
within a requestAnimationFrame callback, and [2] where the 'escape' key is
ignored by the IronOverlayManager if an overlay is not registered yet. 

[1]
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro...
[2]
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro....

Thankfully, if we do finish the transition to native <dialog> we don't have to
worry about requestAnimationFrame here. The part that converts the parallel
sub-tests to serial, will still be relevant though.

[dpapad, 2016-07-07 23:46:16]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-07-07 23:46:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 00:31:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-08 00:32:30]

Description was changed from

==========
MD Settings: Reset page, fix dialog test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Resolved by changing tests to not run in parallel, and fixing test code to
properly test closing using the 'Esc' key.

This bug was revealed while investigating migration to native <dialog>.

BUG=625332
==========

to

==========
MD Settings: Reset page, fix dialog test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Resolved by changing tests to not run in parallel, and fixing test code to
properly test closing using the 'Esc' key.

This bug was revealed while investigating migration to native <dialog>.

BUG=625332

Committed: https://crrev.com/0df9bed02b720adb4c2be76dd8254b9ae3861906
Cr-Commit-Position: refs/heads/master@{#404276}
==========

[commit-bot: I haz the power, 2016-07-08 00:32:31]

Patchset 1 (id:??) landed as
https://crrev.com/0df9bed02b720adb4c2be76dd8254b9ae3861906
Cr-Commit-Position: refs/heads/master@{#404276}