[SublimeText] Get the clang flags with the same script that vim uses

[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with vim's ycm generator which has to do the same thing and has
been in use for quite some time.

BUG=626409
Committed: https://crrev.com/51f4e51682e2241f394ea2c13c6fb2fff039cefb
Cr-Commit-Position: refs/heads/master@{#406480}

[jkarlin, 2016-07-07 18:18:58]

jkarlin@chromium.org changed reviewers:
+ thakis@chromium.org

[jkarlin, 2016-07-07 18:18:58]

thakis: PTAL, thanks!
sashab: FYI

[jkarlin, 2016-07-07 18:19:30]

Description was changed from

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations). Rather than fix it, we should merge with
vim's ycm generator which has to do the same thing and has been in use for
quite some time.

BUG=626409
==========

to

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with
vim's ycm generator which has to do the same thing and has been in use for
quite some time.

BUG=626409
==========

[jkarlin, 2016-07-07 18:19:49]

Description was changed from

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with
vim's ycm generator which has to do the same thing and has been in use for
quite some time.

BUG=626409
==========

to

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with vim's ycm generator which has to do the same thing and has
been in use for quite some time.

BUG=626409
==========

[jkarlin, 2016-07-07 18:28:24]

Patchset #2 (id:20001) has been deleted

[Nico, 2016-07-07 20:11:01]

thakis@chromium.org changed reviewers:
+ sashab@chromium.org

[Nico, 2016-07-07 20:11:02]

sashab should review this.

(why not make sublime/ninja_options_script.py use the vim script, if that's what
you want to do?)

[sashab, 2016-07-08 00:58:27]

https://codereview.chromium.org/2129993002/diff/1/docs/linux_sublime_dev.md
File docs/linux_sublime_dev.md (right):

https://codereview.chromium.org/2129993002/diff/1/docs/linux_sublime_dev.md#n...
docs/linux_sublime_dev.md:303: "sublimeclang_options_script": "python
${project_path}/src/tools/sublime/compile_flags.py -d
'${project_path}/../depot_tools'",
Just for default arguments sake, I would change this to -d
'/path/to/depot_tools'.

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags.py
File tools/sublime/compile_flags.py (right):

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags...
tools/sublime/compile_flags.py:1: #!/usr/bin/python
Just rename this to ninja_options_script.py and delete the current one.

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags...
tools/sublime/compile_flags.py:10: #       -d '${project_path}/../depot_tools'"
-d '/path/to/depot_tools'

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags...
tools/sublime/compile_flags.py:10: #       -d '${project_path}/../depot_tools'"
-d '/path/to/depot_tools'

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags...
tools/sublime/compile_flags.py:14: # and SublimgClang passes the absolute file
path to the current file as an
SublimeClang*

[jkarlin, 2016-07-18 17:47:30]

Patchset #2 (id:40001) has been deleted

[jkarlin, 2016-07-18 17:48:40]

Patchset #2 (id:60001) has been deleted

[jkarlin, 2016-07-18 17:48:55]

Thanks! PTAL sashab@

https://codereview.chromium.org/2129993002/diff/1/docs/linux_sublime_dev.md
File docs/linux_sublime_dev.md (right):

https://codereview.chromium.org/2129993002/diff/1/docs/linux_sublime_dev.md#n...
docs/linux_sublime_dev.md:303: "sublimeclang_options_script": "python
${project_path}/src/tools/sublime/compile_flags.py -d
'${project_path}/../depot_tools'",
On 2016/07/08 00:58:26, sashab wrote:
> Just for default arguments sake, I would change this to -d
> '/path/to/depot_tools'.

Done.

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags.py
File tools/sublime/compile_flags.py (right):

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags...
tools/sublime/compile_flags.py:1: #!/usr/bin/python
On 2016/07/08 00:58:26, sashab wrote:
> Just rename this to ninja_options_script.py and delete the current one.

Done. Note that the parameters are different, so this will break current users.
I can send out a PSA to chromium-dev after landing.

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags...
tools/sublime/compile_flags.py:10: #       -d '${project_path}/../depot_tools'"
On 2016/07/08 00:58:27, sashab wrote:
> -d '/path/to/depot_tools'

Done.

https://codereview.chromium.org/2129993002/diff/1/tools/sublime/compile_flags...
tools/sublime/compile_flags.py:14: # and SublimgClang passes the absolute file
path to the current file as an
On 2016/07/08 00:58:26, sashab wrote:
> SublimeClang*

Done.

[jkarlin, 2016-07-18 17:49:59]

Patchset #2 (id:80001) has been deleted

[sashab, 2016-07-19 06:54:26]

lgtm!! Tyvm

Also chromium-dev PSA for the changed parameters sgtm :)

[jkarlin, 2016-07-19 10:49:50]

jkarlin@chromium.org changed reviewers:
+ dpranke@chromium.org
- thakis@chromium.org

[jkarlin, 2016-07-19 10:50:21]

Thanks! dpranke@ PTAL

[Dirk Pranke, 2016-07-20 02:00:31]

lgtm.

https://codereview.chromium.org/2129993002/diff/100001/tools/sublime/ninja_op...
File tools/sublime/ninja_options_script.py (right):

https://codereview.chromium.org/2129993002/diff/100001/tools/sublime/ninja_op...
tools/sublime/ninja_options_script.py:44: main()
nit: two spaces here?

[jkarlin, 2016-07-20 02:32:22]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[jkarlin, 2016-07-20 02:32:36]

Thanks!

https://codereview.chromium.org/2129993002/diff/100001/tools/sublime/ninja_op...
File tools/sublime/ninja_options_script.py (right):

https://codereview.chromium.org/2129993002/diff/100001/tools/sublime/ninja_op...
tools/sublime/ninja_options_script.py:44: main()
On 2016/07/20 02:00:31, Dirk Pranke wrote:
> nit: two spaces here?

Done.

[jkarlin, 2016-07-20 02:32:43]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2016-07-20 02:32:47]

The CQ bit was checked by jkarlin@chromium.org

[jkarlin, 2016-07-20 02:32:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2129993002/#ps120001
(title: "Remove extra spaces")

[commit-bot: I haz the power, 2016-07-20 02:33:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:22:18]

Description was changed from

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with vim's ycm generator which has to do the same thing and has
been in use for quite some time.

BUG=626409
==========

to

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with vim's ycm generator which has to do the same thing and has
been in use for quite some time.

BUG=626409
==========

[commit-bot: I haz the power, 2016-07-20 04:22:19]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-07-20 04:24:23]

Description was changed from

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with vim's ycm generator which has to do the same thing and has
been in use for quite some time.

BUG=626409
==========

to

==========
[SublimeText] Get the clang flags with the same script that vim uses

The sublime script to get the clang flags doesn't work for many files (e.g.,
those with $ line continuations in the ninja files). Rather than fix it, we
should merge with vim's ycm generator which has to do the same thing and has
been in use for quite some time.

BUG=626409

Committed: https://crrev.com/51f4e51682e2241f394ea2c13c6fb2fff039cefb
Cr-Commit-Position: refs/heads/master@{#406480}
==========

[commit-bot: I haz the power, 2016-07-20 04:24:24]

Patchset 3 (id:??) landed as
https://crrev.com/51f4e51682e2241f394ea2c13c6fb2fff039cefb
Cr-Commit-Position: refs/heads/master@{#406480}