Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: net/http/http_server_properties_manager_unittest.cc

Issue 2129973002: Serialize NPN_HTTP_2 as "h2" instead of "npn-h2". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_server_properties.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_manager_unittest.cc
diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc
index 9b2048ad73186b42f565a3091bdd5947f589501a..51f509496a9735f45f0d09414583ae88cf59d75c 100644
--- a/net/http/http_server_properties_manager_unittest.cc
+++ b/net/http/http_server_properties_manager_unittest.cc
@@ -246,7 +246,7 @@ TEST_P(HttpServerPropertiesManagerTest,
std::unique_ptr<base::DictionaryValue> alternative_service_dict0(
new base::DictionaryValue);
alternative_service_dict0->SetInteger("port", 443);
- alternative_service_dict0->SetString("protocol_str", "npn-h2");
+ alternative_service_dict0->SetString("protocol_str", "h2");
std::unique_ptr<base::DictionaryValue> alternative_service_dict1(
new base::DictionaryValue);
alternative_service_dict1->SetInteger("port", 1234);
@@ -1121,9 +1121,9 @@ TEST_P(HttpServerPropertiesManagerTest, UpdateCacheWithPrefs) {
"\"servers\":["
"{\"http://www.google.com\":{"
"\"alternative_service\":[{\"expiration\":\"13756212000000000\","
- "\"port\":443,\"protocol_str\":\"npn-h2\"},"
+ "\"port\":443,\"protocol_str\":\"h2\"},"
"{\"expiration\":\"13758804000000000\",\"host\":\"www.google.com\","
- "\"port\":1234,\"protocol_str\":\"npn-h2\"}]}},"
+ "\"port\":1234,\"protocol_str\":\"h2\"}]}},"
"{\"http://mail.google.com\":{\"alternative_service\":[{"
"\"expiration\":\"9223372036854775807\",\"host\":\"foo.google.com\","
"\"port\":444,\"protocol_str\":\"npn-spdy/3.1\"}],"
@@ -1142,7 +1142,7 @@ TEST_P(HttpServerPropertiesManagerTest, UpdateCacheWithPrefs) {
TEST_P(HttpServerPropertiesManagerTest, AddToAlternativeServiceMap) {
std::unique_ptr<base::Value> server_value = base::JSONReader::Read(
- "{\"alternative_service\":[{\"port\":443,\"protocol_str\":\"npn-h2\"},"
+ "{\"alternative_service\":[{\"port\":443,\"protocol_str\":\"h2\"},"
"{\"port\":123,\"protocol_str\":\"quic\","
"\"expiration\":\"9223372036854775807\"},{\"host\":\"example.org\","
"\"port\":1234,\"protocol_str\":\"npn-h2\","
Bence 2016/07/07 19:14:38 I left this instance and some others of "npn-h2" a
« no previous file with comments | « net/http/http_server_properties.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698