If we can't rehash the backing store for weak sets & maps, do a last resort GC

If we can't rehash the backing store for weak sets & maps, do a last resort GC

BUG=v8:4909
R=hpayer@chromium.org

Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}

[Hannes Payer (out of office), 2016-07-07 14:26:45]

https://codereview.chromium.org/2129933002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2129933002/diff/1/src/objects.cc#newcode17756
src/objects.cc:17756: isolate->heap()->CollectAllAvailableGarbage(
I am not happy with this CL since it adds another dependency from runtime to GC.
However, I do not see a better solution right now. The HashTable is like the
heap, you have to do GC on OOM.

Can you call CollectGarbage two times instead of CollectAllAvailableGarbage?
This would result in less heavy GCs.

[jochen (gone - plz use gerrit), 2016-07-07 15:05:03]

ptal

[Hannes Payer (out of office), 2016-07-07 15:22:00]

lgtm

https://codereview.chromium.org/2129933002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2129933002/diff/20001/src/objects.cc#newcode1...
src/objects.cc:17759: "last resort gc (object hash table)");
let's not call this last resort gc, to not confuse it with the actual emergency
gc. just call it "full object hash table"

[jochen (gone - plz use gerrit), 2016-07-07 15:24:35]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-07-07 15:24:35]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2129933002/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2016-07-07 15:24:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 15:48:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-07 15:49:52]

Description was changed from

==========
If we can't rehash the backing store for weak sets & maps, do a last resort GC

BUG=v8:4909
R=hpayer@chromium.org
==========

to

==========
If we can't rehash the backing store for weak sets & maps, do a last resort GC

BUG=v8:4909
R=hpayer@chromium.org

Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
==========

[commit-bot: I haz the power, 2016-07-07 15:49:53]

Patchset 3 (id:??) landed as
https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}