Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 212993005: Replaced boto certificate (Closed)

Created:
6 years, 9 months ago by pgervais
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1913 lines, -362 lines) Patch
M third_party/boto/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/boto/cacerts/cacerts.txt View 13 chunks +1912 lines, -362 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pgervais
I gather that the boto library is used only to connect to Google storage, so ...
6 years, 9 months ago (2014-03-26 16:40:29 UTC) #1
ghost stip (do not use)
lgtm, Sleevi for review
6 years, 9 months ago (2014-03-26 19:23:53 UTC) #2
Ryan Sleevi
Are you planning to upgrade Boto from 2.8.0? Notable applicable changes: http://docs.pythonboto.org/en/latest/releasenotes/v2.9.1.html Added OrdinaryCallingFormat to ...
6 years, 9 months ago (2014-03-26 19:37:56 UTC) #3
pgervais
On 2014/03/26 19:37:56, Ryan Sleevi wrote: > Are you planning to upgrade Boto from 2.8.0? ...
6 years, 9 months ago (2014-03-26 20:02:59 UTC) #4
pgervais
Filed crbug.com/356814 to track boto update, and committing this CL soon.
6 years, 9 months ago (2014-03-26 20:16:41 UTC) #5
pgervais
The CQ bit was checked by pgervais@chromium.org
6 years, 9 months ago (2014-03-26 21:13:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgervais@chromium.org/212993005/1
6 years, 9 months ago (2014-03-26 21:13:59 UTC) #7
commit-bot: I haz the power
Change committed as 259692
6 years, 9 months ago (2014-03-26 21:17:30 UTC) #8
Ryan Tseng
6 years, 9 months ago (2014-03-26 23:57:50 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/213963002/ by hinoka@google.com.

The reason for reverting is: This causes download_from_google_storage to fail:
Failure: CA certificates file does not have expected SHA1 sum; expected:
ed024a78d9327f8669b3b117d9eac9e3c9460e9b, actual:
433e5589520cd2f1f29dea3e077cfbc2b74fb78c.

You'll need to also update the expectations on the gsutil side, and then reland.

Test it by running "gsutil ls"..

Powered by Google App Engine
This is Rietveld 408576698