Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2129913005: Revert of Web MIDI: use mojom::blink::PermissionService directly to ask permission (Closed)

Created:
4 years, 5 months ago by hush (inactive)
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, haraken, jam, kinuko+watch, Lalit Maganti, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Web MIDI: use mojom::blink::PermissionService directly to ask permission (patchset #7 id:120001 of https://codereview.chromium.org/2116763002/ ) Reason for revert: This CL is suspected to break org.chromium.webview_shell.test.WebViewLayoutTest#testRequestMIDIAccessDenyPermission org.chromium.webview_shell.test.WebViewLayoutTest#testRequestMIDIAccess https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Webview%20M%20%28dbg%29/builds/11186 Original issue's description: > Web MIDI: use mojom::blink::PermissionService directly to ask permission > > Web MIDI asked permissions via public/web interfaces. > But now that PermissionService is available in Blink, > use the service to ask permissions. > > This migration makes it possible to remove all MIDI > related public/web interfaces. > > BUG=582328 > > Committed: https://crrev.com/15c1a1ffd1f4c620b89191209dc76ef5557dd8fc > Cr-Commit-Position: refs/heads/master@{#404136} TBR=yukishiino@chromium.org,sammc@chromium.org,kinuko@chromium.org,tkent@chromium.org,torne@chromium.org,esprehn@chromium.org,haraken@chromium.org,tobiasjs@chromium.org,toyoshim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582328 Committed: https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb Cr-Commit-Position: refs/heads/master@{#404178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+784 lines, -74 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwPermissionManagerTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A content/renderer/media/midi_dispatcher.h View 1 chunk +56 lines, -0 lines 0 comments Download
A content/renderer/media/midi_dispatcher.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webmidi/loopback-receive.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webmidi/permission.html View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/webmidi/send-messages.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h View 3 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp View 3 chunks +46 lines, -57 lines 0 comments Download
A third_party/WebKit/Source/modules/webmidi/MIDIClient.h View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/webmidi/MIDIController.h View 1 chunk +67 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/webmidi/MIDIController.cpp View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/MIDIClientProxy.h View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/MIDIClientProxy.cpp View 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/WebMIDIPermissionRequest.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 2 chunks +5 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/modules/webmidi/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/modules/webmidi/WebMIDIClient.h View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/modules/webmidi/WebMIDIOptions.h View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/public/web/modules/webmidi/WebMIDIPermissionRequest.h View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hush (inactive)
Created Revert of Web MIDI: use mojom::blink::PermissionService directly to ask permission
4 years, 5 months ago (2016-07-07 18:04:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129913005/1
4 years, 5 months ago (2016-07-07 18:05:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 18:06:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e66467f60aee961c4e216e160863932a6a484fb Cr-Commit-Position: refs/heads/master@{#404178}
4 years, 5 months ago (2016-07-07 18:08:37 UTC) #7
tkent
4 years, 5 months ago (2016-07-07 22:59:10 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698