Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2129913004:
Use sRGB pixel config for ARGB masks (color emoji) (Closed)
|
Created:
4 years, 5 months ago by Brian Osman Modified:
4 years, 5 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionUse sRGB pixel config for ARGB masks (color emoji)
Fixes over-bright color emoji and GM:colortype in sRGB mode
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004
Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a
Committed: https://skia.googlesource.com/skia/+/86dc226b6024c61fa711475aa9fc2cfd53811ccb
Patch Set 1 #Patch Set 2 : Avoid static cache of wrong value #
Total comments: 1
Messages
Total messages: 24 (12 generated)
Description was changed from ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji in sRGB mode BUG=skia: ========== to ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 ==========
The CQ bit was checked by brianosman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 ========== to ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji and GM:colortype in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 ==========
brianosman@google.com changed reviewers: + bungeman@google.com, jvanverth@google.com
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brianosman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji and GM:colortype in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 ========== to ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji and GM:colortype in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2128583007/ by brianosman@google.com. The reason for reverting is: Color text rendering failing on ANGLE.
The CQ bit was checked by brianosman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2129913004/diff/20001/src/gpu/text/GrBatchFon... File src/gpu/text/GrBatchFontCache.h (right): https://codereview.chromium.org/2129913004/diff/20001/src/gpu/text/GrBatchFon... src/gpu/text/GrBatchFontCache.h:190: switch (format) { First version of this change was failing on ANGLE bots: The table is function-static, so we would cache the sRGB pixel config for ARGB masks (when the bots first tested a non-ANGLE config). Then we'd try and run ANGLE (which doesn't support sRGB) and it would still try to use the (unsupported) sRGB config. Doh.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brianosman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from jvanverth@google.com Link to the patchset: https://codereview.chromium.org/2129913004/#ps20001 (title: "Avoid static cache of wrong value")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji and GM:colortype in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a ========== to ========== Use sRGB pixel config for ARGB masks (color emoji) Fixes over-bright color emoji and GM:colortype in sRGB mode BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913004 Committed: https://skia.googlesource.com/skia/+/920af9fac3d9e275a93910d9c626ee7bc23ed17a Committed: https://skia.googlesource.com/skia/+/86dc226b6024c61fa711475aa9fc2cfd53811ccb ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/86dc226b6024c61fa711475aa9fc2cfd53811ccb |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
