ash/common/system/chromeos/network/tray_sms.h - Issue 2129913003: Added UMA Metrics for SMS UI in the status area.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/network/tray_sms.h

Issue 2129913003: Added UMA Metrics for SMS UI in the status area. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated owner & description in actions.xml and other polish. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/system/chromeos/network/tray_sms.h

diff --git a/ash/common/system/chromeos/network/tray_sms.h b/ash/common/system/chromeos/network/tray_sms.h

index c8209a0029def28076b88d3626ba90b943631de5..4ad9322b019ae49bdc8e9cc0adc552e1a6f49d2e 100644

--- a/ash/common/system/chromeos/network/tray_sms.h

+++ b/ash/common/system/chromeos/network/tray_sms.h

@@ -43,8 +43,9 @@ class TraySms : public SystemTrayItem,

// retrieve the numebr and text from the message.

bool GetLatestMessage(size_t* index, std::string* number, std::string* text);

- // Removes message at |index| from message list.

- void RemoveMessage(size_t index);

+ // Removes message at |index| from message list. Returns true if |index| was

+ // valid and a message was removed.

+ bool RemoveMessage(size_t index);

// Called when sms messages have changed (through

// chromeos::NetworkSmsHandler::Observer).