Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129913002: fix for SkSL producing invalid branch after an OpKill (Closed)

Created:
4 years, 5 months ago by ethannicholas
Modified:
4 years, 5 months ago
Reviewers:
dogben, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix for SkSL producing invalid branch after an OpKill GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2129913002 Committed: https://skia.googlesource.com/skia/+/552882f768b02a2aa20552a765913187851e382b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/sksl/SkSLSPIRVCodeGenerator.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129913002/1
4 years, 5 months ago (2016-07-07 13:13:43 UTC) #3
ethannicholas
4 years, 5 months ago (2016-07-07 13:14:05 UTC) #5
dogben
lgtm
4 years, 5 months ago (2016-07-07 13:28:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 13:28:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129913002/1
4 years, 5 months ago (2016-07-07 13:29:53 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 13:30:52 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/552882f768b02a2aa20552a765913187851e382b

Powered by Google App Engine
This is Rietveld 408576698