Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 2129843002: CustomElements: upgrade an element (Closed)

Created:
4 years, 5 months ago by davaajav
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CustomElements: upgrade an element Step 6. Testing execution order of reactions, when the constructor non-conformantly uses API decorated with the [CEReactions] Step 8. The constructor throws Step 9. Value returned by the constructor is different from element BUG=594918 Committed: https://crrev.com/da3577f8e2965c4b7e041a2b0c0446ab8e6f2e94 Cr-Commit-Position: refs/heads/master@{#405697}

Patch Set 1 #

Total comments: 4

Patch Set 2 : patch update #

Patch Set 3 : patch update #

Patch Set 4 : added failure expectation #

Messages

Total messages: 15 (5 generated)
davaajav
PTL
4 years, 5 months ago (2016-07-07 08:02:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129843002/1
4 years, 5 months ago (2016-07-07 08:27:44 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/256026)
4 years, 5 months ago (2016-07-07 09:25:44 UTC) #6
dominicc (has gone to gerrit)
Some comments inline. Any idea why these failed on some of the bots? https://codereview.chromium.org/2129843002/diff/1/third_party/WebKit/LayoutTests/custom-elements/spec/upgrade-element.html File ...
4 years, 5 months ago (2016-07-13 07:06:18 UTC) #7
davaajav
PTL
4 years, 5 months ago (2016-07-13 07:41:20 UTC) #8
davaajav
PTL
4 years, 5 months ago (2016-07-14 08:22:15 UTC) #9
dominicc (has gone to gerrit)
lgtm
4 years, 5 months ago (2016-07-15 02:25:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129843002/60001
4 years, 5 months ago (2016-07-15 02:26:19 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-15 04:28:13 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 04:29:39 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/da3577f8e2965c4b7e041a2b0c0446ab8e6f2e94
Cr-Commit-Position: refs/heads/master@{#405697}

Powered by Google App Engine
This is Rietveld 408576698