Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Issue 212983012: Fix build when compiling with the clang plugin. (Closed)

Created:
6 years, 9 months ago by zerny-chromium
Modified:
6 years, 9 months ago
CC:
blink-reviews, timvolodine, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com, mvanouwerkerk+watch_chromium.org, Inactive, oilpan-reviews
Visibility:
Public.

Description

Fix build when compiling with the clang plugin. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/modules/device_orientation/DeviceOrientationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
zerny-chromium
Adds an annotation and replaces member by persistent to ensure tracing from an off-heap class. ...
6 years, 9 months ago (2014-03-27 13:19:32 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-27 13:24:56 UTC) #2
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-27 13:33:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
6 years, 9 months ago (2014-03-27 13:33:27 UTC) #4
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-27 13:52:38 UTC) #5
dgozman
Sorry for confusing Member and Persistent... lgtm
6 years, 9 months ago (2014-03-27 13:54:56 UTC) #6
zerny-chromium
> Sorry for confusing Member and Persistent... No problem. Usually it should be a Member, ...
6 years, 9 months ago (2014-03-27 14:06:54 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 14:14:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 14:14:20 UTC) #9
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-27 15:00:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
6 years, 9 months ago (2014-03-27 15:00:47 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:26:42 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 15:26:43 UTC) #13
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-27 20:37:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
6 years, 9 months ago (2014-03-27 20:37:48 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:32:38 UTC) #16
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:32:39 UTC) #17
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-27 23:02:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
6 years, 9 months ago (2014-03-27 23:02:52 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:12:11 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 00:12:13 UTC) #21
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-28 01:08:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
6 years, 9 months ago (2014-03-28 01:08:52 UTC) #23
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 02:12:32 UTC) #24
Message was sent while issue was closed.
Change committed as 170247

Powered by Google App Engine
This is Rietveld 408576698