|
|
Created:
6 years, 9 months ago by zerny-chromium Modified:
6 years, 9 months ago CC:
blink-reviews, timvolodine, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com, mvanouwerkerk+watch_chromium.org, Inactive, oilpan-reviews Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionFix build when compiling with the clang plugin.
BUG=
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170247
Patch Set 1 #
Messages
Total messages: 24 (0 generated)
Adds an annotation and replaces member by persistent to ensure tracing from an off-heap class. PTAL
LGTM
The CQ bit was checked by zerny@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
lgtm
Sorry for confusing Member and Persistent... lgtm
> Sorry for confusing Member and Persistent... No problem. Usually it should be a Member, and then the member field needs to be traced from a trace method. However, in this case DeviceOrientationController is not yet GC managed (ie, derived from GarbageCollected or GarbageCollectedFinalize) and so we need to use a Persistent while transitioning the code.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on win_blink_rel
The CQ bit was checked by zerny@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by zerny@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/212983012/1
Message was sent while issue was closed.
Change committed as 170247 |