Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: Source/bindings/bindings.gypi

Issue 212983010: Make EventInterfaces.in build step not depend on bindings generation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reorder Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core_bindings_generated.gyp » ('j') | Source/bindings/generated_bindings.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/bindings.gypi
diff --git a/Source/bindings/bindings.gypi b/Source/bindings/bindings.gypi
index e06c0093532d53a07c1e36e1fa2c551e90e52157..797d4ff26e536e91854f3553064d49c9edffd1cf 100644
--- a/Source/bindings/bindings.gypi
+++ b/Source/bindings/bindings.gypi
@@ -1,6 +1,8 @@
{
'variables': {
- 'bindings_dir': ['.'],
+ 'bindings_v8_dir': 'v8',
Nils Barth (inactive) 2014/04/01 06:20:38 Only actually used for bindings/v8, so be explicit
+ 'blink_output_dir': '<(SHARED_INTERMEDIATE_DIR)/blink',
+ 'bindings_output_dir': '<(SHARED_INTERMEDIATE_DIR)/blink/bindings',
'bindings_files': [
'v8/ActiveDOMCallback.cpp',
'v8/ActiveDOMCallback.h',
@@ -249,33 +251,47 @@
],
'conditions': [
['OS=="win" and buildtype=="Official"', {
- # On windows official release builds, we try to preserve symbol space.
+ # On Windows Official release builds, we try to preserve symbol
+ # space.
'aggregate_generated_bindings_files': [
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings.cpp',
],
}, {
'aggregate_generated_bindings_files': [
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings01.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings02.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings03.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings04.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings05.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings06.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings07.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings08.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings09.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings10.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings11.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings12.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings13.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings14.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings15.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings16.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings17.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings18.cpp',
- '<(SHARED_INTERMEDIATE_DIR)/blink/bindings/V8GeneratedBindings19.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings01.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings02.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings03.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings04.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings05.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings06.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings07.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings08.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings09.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings10.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings11.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings12.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings13.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings14.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings15.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings16.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings17.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings18.cpp',
+ '<(bindings_output_dir)/V8GeneratedBindings19.cpp',
],
}],
+
+ # The bindings generator can skip writing generated files if they
+ # are identical to the already existing file, which avoids
+ # recompilation. However, a dependency (earlier build step) having
+ # a newer timestamp than an output (later build step) confuses some
+ # build systems, so only use this on ninja, which explicitly
+ # supports this use case (gyp turns all actions into ninja restat
+ # rules).
+ ['"<(GENERATOR)"=="ninja"', {
+ 'write_file_only_if_changed': '1',
+ }, {
+ 'write_file_only_if_changed': '0',
+ }],
],
},
}
« no previous file with comments | « no previous file | Source/bindings/core_bindings_generated.gyp » ('j') | Source/bindings/generated_bindings.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698