Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 212983007: When firing null-events stop DeviceSensorEventController only after the event has propagated to win… (Closed)

Created:
6 years, 9 months ago by timvolodine
Modified:
6 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

When firing null-events stop DeviceSensorEventController only after the event has propagated to window. When no sensors are available chrome should fire an all-null event into blink. However at the time of firing the active DOM objects can be suspended or stopped, which can prohibit propagation of the event to window. Currently the controller will be unregistered in any case because the event is a null-event. This results in the potential loss of null-events and the javascript callback is never executed. To avoid this issue the firing of a null-event should happen until it effectively propagates to window. BUG=356750 TEST=http://jsbin.com/pivimoga/1/ (manual) TEST=https://codereview.chromium.org/214763002/ (browsertest) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/frame/DeviceSensorEventController.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
timvolodine
6 years, 9 months ago (2014-03-26 19:48:46 UTC) #1
abarth-chromium
Test?
6 years, 9 months ago (2014-03-27 03:30:17 UTC) #2
abarth-chromium
lgtm assuming you add a test
6 years, 9 months ago (2014-03-27 03:30:27 UTC) #3
timvolodine
On 2014/03/27 03:30:27, abarth wrote: > lgtm assuming you add a test Thanks Adam. Not ...
6 years, 8 months ago (2014-03-27 14:55:26 UTC) #4
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 8 months ago (2014-03-27 19:04:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/212983007/1
6 years, 8 months ago (2014-03-27 19:04:42 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-03-27 20:03:06 UTC) #7
Message was sent while issue was closed.
Change committed as 170200

Powered by Google App Engine
This is Rietveld 408576698