Issue 212983003: Implement auto-roll script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212983003: Implement auto-roll script. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach

Modified:
6 years, 8 months ago

Reviewers:
Jarin

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement auto-roll script. This script will (1) check if there is an active roll on rietveld (2) check if there is a trunk revision ready to be rolled and (3) call the chromium_roll script, creating a roll CL. The script will be called regularly through a cron job. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20422

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -6 lines)			Patch
A	tools/push-to-trunk/auto_roll.py	View	1	1 chunk	+107 lines, -0 lines	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View		3 chunks	+66 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jarin

lgtm. https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/auto_roll.py File tools/push-to-trunk/auto_roll.py (right): https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/auto_roll.py#newcode93 tools/push-to-trunk/auto_roll.py:93: print "A author (-a) is required." Nit: "A" ...

6 years, 8 months ago (2014-04-02 06:30:39 UTC) #3

Michael Achenbach

6 years, 8 months ago (2014-04-02 06:59:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20422 (presubmit successful).

Expand Messages | Collapse Messages