Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 21298: Make accelerators work in interstitial pages (Closed)

Created:
11 years, 10 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

This make accelerators work in interstitial pages. Interstitial pages are RVH whose view is shown on top of the actual tab. Some more work is required to make find in page work. BUG=7056 TEST=Open an page that triggers an interstitial (ex: https://ebay.com), press CTRL-T, a new tab should be opened. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10316

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -2 lines) Patch
M chrome/browser/tab_contents/interstitial_page.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 5 chunks +99 lines, -2 lines 0 comments Download
M chrome/browser/views/tab_contents_container_view.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 10 months ago (2009-02-12 19:15:34 UTC) #1
Ben Goodger (Google)
11 years, 10 months ago (2009-02-24 21:47:04 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698