Issue 21298: Make accelerators work in interstitial pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21298: Make accelerators work in interstitial pages (Closed)

Created:
11 years, 10 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This make accelerators work in interstitial pages. Interstitial pages are RVH whose view is shown on top of the actual tab. Some more work is required to make find in page work. BUG=7056 TEST=Open an page that triggers an interstitial (ex: https://ebay.com), press CTRL-T, a new tab should be opened. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10316

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -2 lines)			Patch
M	chrome/browser/tab_contents/interstitial_page.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/interstitial_page.cc	View	1	5 chunks	+99 lines, -2 lines	0 comments	Download
M	chrome/browser/views/tab_contents_container_view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages