Remove linear-function easing TypeError exemption.

Remove linear-function easing TypeError exemption.

Invalid values for 'easing' should throw a TypeError
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).
In crrev.com/1851003002, this was implemented for all invalid values except
"function (a){return a}", as described in the bug referenced below. The
incidence of this special case is below the feature removal threshold. This
patch removes the exemption, bringing the code in line with the spec.

BUG=601672
Committed: https://crrev.com/5c2c07865e41b3cbb10e8c77508b7f86709a7ce3
Cr-Commit-Position: refs/heads/master@{#412465}

[suzyh_UTC10 (ex-contributor), 2016-07-07 00:34:07]

suzyh@chromium.org changed reviewers:
+ dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-07-07 00:36:12]

The use counter information is available at
https://www.chromestatus.com/metrics/feature/timeline/popularity/1295
https://www.chromestatus.com/metrics/feature/timeline/popularity/1296
and
go/vwori (internal link).

[dstockwell, 2016-07-08 01:13:22]

On 2016/07/07 at 00:36:12, suzyh wrote:
> The use counter information is available at
> https://www.chromestatus.com/metrics/feature/timeline/popularity/1295
> https://www.chromestatus.com/metrics/feature/timeline/popularity/1296
> and
> go/vwori (internal link).

The counter is under the threshold, but the usage is still surprisingly high.
Overall element.animate usage is around 0.03% and this is almost half of that.
Do we know which pages are still hitting this?

[suzyh_UTC10 (ex-contributor), 2016-07-14 04:29:45]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 04:30:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 06:15:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 06:15:32]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-08-08 01:02:58]

On 2016/07/08 at 01:13:22, dstockwell wrote:
> On 2016/07/07 at 00:36:12, suzyh wrote:
> > The use counter information is available at
> > https://www.chromestatus.com/metrics/feature/timeline/popularity/1295
> > https://www.chromestatus.com/metrics/feature/timeline/popularity/1296
> > and
> > go/vwori (internal link).
> 
> The counter is under the threshold, but the usage is still surprisingly high.
Overall element.animate usage is around 0.03% and this is almost half of that.
Do we know which pages are still hitting this?

I've been trying to get data on what pages are hitting this use counter but
without success. The count is, however, dropping, while overall Element.animate
usage is increasing, and recently saw a big jump:
https://www.chromestatus.com/metrics/feature/timeline/popularity/773

Are you happy for me to remove this and just respond to extra bug reports if
they come in?

[suzyh_UTC10 (ex-contributor), 2016-08-08 01:45:00]

On 2016/08/08 at 01:02:58, suzyh wrote:
> On 2016/07/08 at 01:13:22, dstockwell wrote:
> > On 2016/07/07 at 00:36:12, suzyh wrote:
> > > The use counter information is available at
> > > https://www.chromestatus.com/metrics/feature/timeline/popularity/1295
> > > https://www.chromestatus.com/metrics/feature/timeline/popularity/1296
> > > and
> > > go/vwori (internal link).
> > 
> > The counter is under the threshold, but the usage is still surprisingly
high. Overall element.animate usage is around 0.03% and this is almost half of
that. Do we know which pages are still hitting this?
> 
> I've been trying to get data on what pages are hitting this use counter but
without success. The count is, however, dropping, while overall Element.animate
usage is increasing, and recently saw a big jump:
https://www.chromestatus.com/metrics/feature/timeline/popularity/773
> 
> Are you happy for me to remove this and just respond to extra bug reports if
they come in?

As discussed offline, I'll hold off on the removal until after the next branch
point.

[suzyh_UTC10 (ex-contributor), 2016-08-16 01:18:16]

On 2016/08/08 at 01:45:00, suzyh wrote:
> On 2016/08/08 at 01:02:58, suzyh wrote:
> > On 2016/07/08 at 01:13:22, dstockwell wrote:
> > > On 2016/07/07 at 00:36:12, suzyh wrote:
> > > > The use counter information is available at
> > > > https://www.chromestatus.com/metrics/feature/timeline/popularity/1295
> > > > https://www.chromestatus.com/metrics/feature/timeline/popularity/1296
> > > > and
> > > > go/vwori (internal link).
> > > 
> > > The counter is under the threshold, but the usage is still surprisingly
high. Overall element.animate usage is around 0.03% and this is almost half of
that. Do we know which pages are still hitting this?
> > 
> > I've been trying to get data on what pages are hitting this use counter but
without success. The count is, however, dropping, while overall Element.animate
usage is increasing, and recently saw a big jump:
https://www.chromestatus.com/metrics/feature/timeline/popularity/773
> > 
> > Are you happy for me to remove this and just respond to extra bug reports if
they come in?
> 
> As discussed offline, I'll hold off on the removal until after the next branch
point.

In the last week, incidence of this use counter has dropped precipitously:
https://www.chromestatus.com/metrics/feature/timeline/popularity/1295

What do you think about removing the exemption in time for the M54 branch point
after all?

[dstockwell, 2016-08-17 01:03:08]

lgtm

[suzyh_UTC10 (ex-contributor), 2016-08-17 03:15:30]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2016-08-17 03:15:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 03:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 03:18:14]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[suzyh_UTC10 (ex-contributor), 2016-08-17 03:20:09]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-08-17 03:20:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2129783003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-17 03:20:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 03:22:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 03:22:54]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[suzyh_UTC10 (ex-contributor), 2016-08-17 03:37:40]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-08-17 03:37:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2129783003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-17 03:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 07:02:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 07:02:45]

Failed to apply patch for
third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt:
While running git rm
third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt;
  fatal: pathspec
'third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt'
did not match any files

Patch:  D   
third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt
Index:
third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt
diff --git
a/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt
b/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt
deleted file mode 100644
index
5c33c31bc6c6bd6d9d4b88c9ade3214f5836850e..0000000000000000000000000000000000000000
---
a/third_party/WebKit/LayoutTests/web-animations-api/animation-effect-timing-easing-expected.txt
+++ /dev/null
@@ -1,8 +0,0 @@
-CONSOLE WARNING: line 9: Specifying animation easing as a function is
deprecated and all support will be removed in M54, around October 2016, at which
point this will throw a TypeError. This warning may have been triggered by the
Web Animations or Polymer polyfills. See http://crbug.com/601672 for details.
-This is a testharness.js-based test.
-PASS Valid easing functions should come out the same as they went in 
-PASS steps easing second parameter defaults to end 
-PASS Should accept arbitrary casing and escape chararcters 
-FAIL Invalid easing values should throw a TypeError assert_throws: with
inputEasing='function (a){return a}' function "function () {
animate_with_easing(inputEasing); }" did not throw
-Harness: the test ran to completion.
-

[commit-bot: I haz the power, 2016-08-17 07:03:06]

Description was changed from

==========
Remove linear-function easing TypeError exemption.

Invalid values for 'easing' should throw a TypeError
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).
In crrev.com/1851003002, this was implemented for all invalid values except
"function (a){return a}", as described in the bug referenced below. The
incidence of this special case is below the feature removal threshold. This
patch removes the exemption, bringing the code in line with the spec.

BUG=601672
==========

to

==========
Remove linear-function easing TypeError exemption.

Invalid values for 'easing' should throw a TypeError
(http://w3c.github.io/web-animations/#dom-animationeffecttiming-easing).
In crrev.com/1851003002, this was implemented for all invalid values except
"function (a){return a}", as described in the bug referenced below. The
incidence of this special case is below the feature removal threshold. This
patch removes the exemption, bringing the code in line with the spec.

BUG=601672

Committed: https://crrev.com/5c2c07865e41b3cbb10e8c77508b7f86709a7ce3
Cr-Commit-Position: refs/heads/master@{#412465}
==========

[commit-bot: I haz the power, 2016-08-17 07:03:07]

Patchset 4 (id:??) landed as
https://crrev.com/5c2c07865e41b3cbb10e8c77508b7f86709a7ce3
Cr-Commit-Position: refs/heads/master@{#412465}