ash/common/ash_switches.h - Issue 2129773002: [CrOS] Initial rough cut of alt-tab window cycling UI.

Side by Side Diff: ash/common/ash_switches.h

Issue 2129773002: [CrOS] Initial rough cut of alt-tab window cycling UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ash/ash.gyp ('k') | ash/common/ash_switches.cc » ('j') | ash/wm/window_cycle_list.h » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ASH_COMMON_ASH_SWITCHES_H_	5 #ifndef ASH_COMMON_ASH_SWITCHES_H_

6 #define ASH_COMMON_ASH_SWITCHES_H_	6 #define ASH_COMMON_ASH_SWITCHES_H_

7	7

8 #include "ash/ash_export.h"	8 #include "ash/ash_export.h"

9	9

10 #include "build/build_config.h"	10 #include "build/build_config.h"

(...skipping 20 matching lines...) Expand all Loading...
31 ASH_EXPORT extern const char kAshEnableTouchView[];	31 ASH_EXPORT extern const char kAshEnableTouchView[];

32 ASH_EXPORT extern const char kAshEnableUnifiedDesktop[];	32 ASH_EXPORT extern const char kAshEnableUnifiedDesktop[];

33 #endif	33 #endif

34 ASH_EXPORT extern const char kAshEnableMirroredScreen[];	34 ASH_EXPORT extern const char kAshEnableMirroredScreen[];

35 ASH_EXPORT extern const char kAshDisableStableOverviewOrder[];	35 ASH_EXPORT extern const char kAshDisableStableOverviewOrder[];

36 ASH_EXPORT extern const char kAshEnableStableOverviewOrder[];	36 ASH_EXPORT extern const char kAshEnableStableOverviewOrder[];

37 ASH_EXPORT extern const char kAshEnableSoftwareMirroring[];	37 ASH_EXPORT extern const char kAshEnableSoftwareMirroring[];

38 ASH_EXPORT extern const char kAshDisableSystemSounds[];	38 ASH_EXPORT extern const char kAshDisableSystemSounds[];

39 ASH_EXPORT extern const char kAshEnableSystemSounds[];	39 ASH_EXPORT extern const char kAshEnableSystemSounds[];

40 ASH_EXPORT extern const char kAshEnableTouchViewTesting[];	40 ASH_EXPORT extern const char kAshEnableTouchViewTesting[];

	41 ASH_EXPORT extern const char kAshEnableWindowCycleUi[];
	Daniel Erat 2016/07/06 22:04:47 nit: highly unscientific, but "UI" looks like it's nit: highly unscientific, but "UI" looks like it's probably much more common than "Ui" in class (and presumably also constant) names: % git grep 'class .UI. {' \| wc -l 720 % git grep 'class .Ui. {' \| wc -l 33 Evan Stade 2016/07/06 23:02:59 Yea, Chrome does it wrong in most places. The goog Show quoted text On 2016/07/06 22:04:47, Daniel Erat wrote: > nit: highly unscientific, but "UI" looks like it's probably much more common > than "Ui" in class (and presumably also constant) names: > > % git grep 'class .UI. {' \| wc -l > 720 > % git grep 'class .Ui. {' \| wc -l > 33 Yea, Chrome does it wrong in most places. The google style guide specifies this should be Ui so I always use Ui (or Md, or Api, etc.) in new code. Daniel Erat 2016/07/06 23:47:30 fair enough. i actually checked the chromium style Show quoted text On 2016/07/06 23:02:59, Evan Stade wrote: > On 2016/07/06 22:04:47, Daniel Erat wrote: > > nit: highly unscientific, but "UI" looks like it's probably much more common > > than "Ui" in class (and presumably also constant) names: > > > > % git grep 'class .UI. {' \| wc -l > > 720 > > % git grep 'class .Ui. {' \| wc -l > > 33 > > Yea, Chrome does it wrong in most places. The google style guide specifies this > should be Ui so I always use Ui (or Md, or Api, etc.) in new code. fair enough. i actually checked the chromium style guide today but got a cached version (looked like http://web.archive.org/web/20160601170106/https://www.chromium.org/developers...), which has some example functions with names like "OK3ReallyLongFunctionName", which made me think that we don't lowercase the trailing letters in abbreviations. (the google c++ guide still has an "IsOK" example at https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D..., but that one's probably hard to change in the underlying code.) Evan Stade 2016/07/07 15:24:42 I guess that might be a bug in the guide? The part Show quoted text On 2016/07/06 23:47:30, Daniel Erat wrote: > On 2016/07/06 23:02:59, Evan Stade wrote: > > On 2016/07/06 22:04:47, Daniel Erat wrote: > > > nit: highly unscientific, but "UI" looks like it's probably much more common > > > than "Ui" in class (and presumably also constant) names: > > > > > > % git grep 'class .UI. {' \| wc -l > > > 720 > > > % git grep 'class .Ui. {' \| wc -l > > > 33 > > > > Yea, Chrome does it wrong in most places. The google style guide specifies > this > > should be Ui so I always use Ui (or Md, or Api, etc.) in new code. > > fair enough. i actually checked the chromium style guide today but got a cached > version (looked like > http://web.archive.org/web/20160601170106/https://www.chromium.org/developers...), > which has some example functions with names like "OK3ReallyLongFunctionName", > which made me think that we don't lowercase the trailing letters in > abbreviations. (the google c++ guide still has an "IsOK" example at > https://google.github.io/styleguide/cppguide.html#Function_Declarations_and_D..., > but that one's probably hard to change in the underlying code.) I guess that might be a bug in the guide? The part I was referring to says "(i.e. StartRpc(), not StartRPC())."
41 ASH_EXPORT extern const char kAshHideNotificationsForFactory[];	42 ASH_EXPORT extern const char kAshHideNotificationsForFactory[];

42 ASH_EXPORT extern const char kAshHostWindowBounds[];	43 ASH_EXPORT extern const char kAshHostWindowBounds[];

43 ASH_EXPORT extern const char kAshMaterialDesign[];	44 ASH_EXPORT extern const char kAshMaterialDesign[];

44 ASH_EXPORT extern const char kAshMaterialDesignDisabled[];	45 ASH_EXPORT extern const char kAshMaterialDesignDisabled[];

45 ASH_EXPORT extern const char kAshMaterialDesignEnabled[];	46 ASH_EXPORT extern const char kAshMaterialDesignEnabled[];

46 ASH_EXPORT extern const char kAshMaterialDesignExperimental[];	47 ASH_EXPORT extern const char kAshMaterialDesignExperimental[];

47 ASH_EXPORT extern const char kAshSecondaryDisplayLayout[];	48 ASH_EXPORT extern const char kAshSecondaryDisplayLayout[];

48 ASH_EXPORT extern const char kAshTouchHud[];	49 ASH_EXPORT extern const char kAshTouchHud[];

49 ASH_EXPORT extern const char kAshUseFirstDisplayAsInternal[];	50 ASH_EXPORT extern const char kAshUseFirstDisplayAsInternal[];

50 ASH_EXPORT extern const char kAuraLegacyPowerButton[];	51 ASH_EXPORT extern const char kAuraLegacyPowerButton[];

51 #if defined(OS_WIN)	52 #if defined(OS_WIN)

52 ASH_EXPORT extern const char kForceAshToDesktop[];	53 ASH_EXPORT extern const char kForceAshToDesktop[];

53 #endif	54 #endif

54	55

55 #if defined(OS_CHROMEOS)	56 #if defined(OS_CHROMEOS)

56 // True if the pointer (cursor) position should be kept inside root windows.	57 // True if the pointer (cursor) position should be kept inside root windows.

57 ASH_EXPORT bool ConstrainPointerToRoot();	58 ASH_EXPORT bool ConstrainPointerToRoot();

58 #endif	59 #endif

59	60

60 } // namespace switches	61 } // namespace switches

61 } // namespace ash	62 } // namespace ash

62	63

63 #endif // ASH_COMMON_ASH_SWITCHES_H_	64 #endif // ASH_COMMON_ASH_SWITCHES_H_

OLD	NEW