Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2129743002: Disable ArcAppModelBuilderTest.RequestShortcutIcons on ChromeOS (Closed)

Created:
4 years, 5 months ago by brucedawson
Modified:
4 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca, xc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ArcAppModelBuilderTest.RequestShortcutIcons on ChromeOS BUG=624446 Committed: https://crrev.com/c8d3d53820d4fa0c06fe46ac4279e7f88992a5df Cr-Commit-Position: refs/heads/master@{#403946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
brucedawson
This test has been flaky since it was created - disabling until it can be ...
4 years, 5 months ago (2016-07-06 19:47:43 UTC) #2
stevenjb
I prioritized the associated issue. Otherwise LGTM.
4 years, 5 months ago (2016-07-06 19:56:03 UTC) #3
brucedawson
On 2016/07/06 19:56:03, stevenjb wrote: > I prioritized the associated issue. Otherwise LGTM. Thanks for ...
4 years, 5 months ago (2016-07-06 19:57:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129743002/1
4 years, 5 months ago (2016-07-06 19:58:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 20:40:11 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 20:40:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 20:43:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8d3d53820d4fa0c06fe46ac4279e7f88992a5df
Cr-Commit-Position: refs/heads/master@{#403946}

Powered by Google App Engine
This is Rietveld 408576698