|
|
Description[Material][Mac]Replaced hard coded Omnibox vectors
Removed the hard coded drawings for the Omnibox vector icons.
Replace them with a call to CreateVectorIcon()
BUG=621302
Committed: https://crrev.com/bfccc541278834822ffa03ce50252fe258c58d13
Cr-Commit-Position: refs/heads/master@{#405201}
Patch Set 1 #
Messages
Total messages: 22 (10 generated)
spqchan@chromium.org changed reviewers: + shrike@chromium.org
PTAL
FYI I looked at this on my desktop yesterday and it looked good, but I need to try on my Retina laptop. Unfortunately the tree is closed so I can't update my repo.
lgtm
spqchan@chromium.org changed reviewers: + thakis@chromium.org
+thakis for OWNERS
Description was changed from ========== [Material][Mac]Replaced hard coded Omnibox vectors BUG=621302 ========== to ========== [Material][Mac]Replaced hard coded Omnibox vectors Removed the hard coded drawings for the Omnibox vector icons. Replace them with a call to CreateVectorIcon() BUG=621302 ==========
rs-lgtm
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by spqchan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Material][Mac]Replaced hard coded Omnibox vectors Removed the hard coded drawings for the Omnibox vector icons. Replace them with a call to CreateVectorIcon() BUG=621302 ========== to ========== [Material][Mac]Replaced hard coded Omnibox vectors Removed the hard coded drawings for the Omnibox vector icons. Replace them with a call to CreateVectorIcon() BUG=621302 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Material][Mac]Replaced hard coded Omnibox vectors Removed the hard coded drawings for the Omnibox vector icons. Replace them with a call to CreateVectorIcon() BUG=621302 ========== to ========== [Material][Mac]Replaced hard coded Omnibox vectors Removed the hard coded drawings for the Omnibox vector icons. Replace them with a call to CreateVectorIcon() BUG=621302 Committed: https://crrev.com/bfccc541278834822ffa03ce50252fe258c58d13 Cr-Commit-Position: refs/heads/master@{#405201} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/bfccc541278834822ffa03ce50252fe258c58d13 Cr-Commit-Position: refs/heads/master@{#405201} |