Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2129723003: [Material][Mac]Replaced hard coded Omnibox vectors (Closed)

Created:
4 years, 5 months ago by spqchan
Modified:
4 years, 5 months ago
Reviewers:
Nico, shrike
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Material][Mac]Replaced hard coded Omnibox vectors Removed the hard coded drawings for the Omnibox vector icons. Replace them with a call to CreateVectorIcon() BUG=621302 Committed: https://crrev.com/bfccc541278834822ffa03ce50252fe258c58d13 Cr-Commit-Position: refs/heads/master@{#405201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -175 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +4 lines, -175 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
spqchan
PTAL
4 years, 5 months ago (2016-07-06 21:01:23 UTC) #2
shrike
FYI I looked at this on my desktop yesterday and it looked good, but I ...
4 years, 5 months ago (2016-07-07 23:30:01 UTC) #3
shrike
lgtm
4 years, 5 months ago (2016-07-08 21:30:40 UTC) #4
spqchan
+thakis for OWNERS
4 years, 5 months ago (2016-07-08 23:34:06 UTC) #6
Nico
rs-lgtm
4 years, 5 months ago (2016-07-11 18:30:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129723003/1
4 years, 5 months ago (2016-07-11 23:05:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260479)
4 years, 5 months ago (2016-07-12 02:05:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129723003/1
4 years, 5 months ago (2016-07-12 16:57:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261141)
4 years, 5 months ago (2016-07-12 20:23:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129723003/1
4 years, 5 months ago (2016-07-13 16:21:29 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 17:07:21 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:10:26 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfccc541278834822ffa03ce50252fe258c58d13
Cr-Commit-Position: refs/heads/master@{#405201}

Powered by Google App Engine
This is Rietveld 408576698