Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: content/renderer/browser_plugin/browser_plugin_bindings.cc

Issue 21297005: <webview>: Refactor Permission API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_permissions
Patch Set: Merge with ToT Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin_bindings.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.cc b/content/renderer/browser_plugin/browser_plugin_bindings.cc
index f7e66140c8f9c9911d0a764a56131d930ff3fb48..a1025580cbe1db43948c1fcc05f0a4c0c70ea2e6 100644
--- a/content/renderer/browser_plugin/browser_plugin_bindings.cc
+++ b/content/renderer/browser_plugin/browser_plugin_bindings.cc
@@ -327,32 +327,6 @@ class BrowserPluginBindingTrackObjectLifetime
DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingTrackObjectLifetime);
};
-// Note: This is a method that is used internally by the <webview> shim only.
-// This should not be exposed to developers.
-class BrowserPluginBindingSetPermission : public BrowserPluginMethodBinding {
- public:
- BrowserPluginBindingSetPermission()
- : BrowserPluginMethodBinding(
- browser_plugin::kMethodInternalSetPermission, 3) {
- }
-
- virtual bool Invoke(BrowserPluginBindings* bindings,
- const NPVariant* args,
- NPVariant* result) OVERRIDE {
- int request_id = IntFromNPVariant(args[0]);
- bool allow = NPVARIANT_TO_BOOLEAN(args[1]);
- std::string user_input = StringFromNPVariant(args[2]);
- bool request_was_pending =
- bindings->instance()->RespondPermissionIfRequestIsPending(
- request_id, allow, user_input);
- BOOLEAN_TO_NPVARIANT(request_was_pending, *result);
- return true;
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(BrowserPluginBindingSetPermission);
-};
-
// BrowserPluginPropertyBinding ------------------------------------------------
class BrowserPluginPropertyBinding {
@@ -712,7 +686,6 @@ BrowserPluginBindings::BrowserPluginBindings(BrowserPlugin* instance)
method_bindings_.push_back(new BrowserPluginBindingAttach);
method_bindings_.push_back(new BrowserPluginBindingAttachWindowTo);
method_bindings_.push_back(new BrowserPluginBindingGetGuestInstanceID);
- method_bindings_.push_back(new BrowserPluginBindingSetPermission);
method_bindings_.push_back(new BrowserPluginBindingTrackObjectLifetime);
property_bindings_.push_back(new BrowserPluginPropertyBindingAutoSize);
« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698