Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: content/common/browser_plugin/browser_plugin_messages.h

Issue 21297005: <webview>: Refactor Permission API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_permissions
Patch Set: Addressed nit Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/browser_plugin/browser_plugin_messages.h
diff --git a/content/common/browser_plugin/browser_plugin_messages.h b/content/common/browser_plugin/browser_plugin_messages.h
index 24275517a5682cb3ad2079a8acad9905ad41ae55..5f70c09cb3217adf256fd27e3f3d5de0cb72f9ae 100644
--- a/content/common/browser_plugin/browser_plugin_messages.h
+++ b/content/common/browser_plugin/browser_plugin_messages.h
@@ -12,10 +12,10 @@
#include "base/values.h"
#include "cc/output/compositor_frame.h"
#include "cc/output/compositor_frame_ack.h"
-#include "content/common/browser_plugin/browser_plugin_message_enums.h"
#include "content/common/content_export.h"
#include "content/common/content_param_traits.h"
#include "content/common/edit_command.h"
+#include "content/public/common/browser_plugin/browser_plugin_message_enums.h"
#include "content/public/common/common_param_traits.h"
#include "content/public/common/drop_data.h"
#include "ipc/ipc_channel_handle.h"
@@ -34,7 +34,6 @@
#define IPC_MESSAGE_START BrowserPluginMsgStart
-IPC_ENUM_TRAITS(BrowserPluginPermissionType)
IPC_ENUM_TRAITS(WebKit::WebDragStatus)
IPC_STRUCT_BEGIN(BrowserPluginHostMsg_AutoSize_Params)
@@ -248,19 +247,6 @@ IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_SetName,
int /* instance_id */,
std::string /* name */)
-// Tells the guest that its request for an API permission has been allowed or
-// denied.
-// Note that |allow| = true does not readily mean that the guest will be granted
-// permission, since a security check in the embedder might follow. For example
-// for media access permission, the guest will be granted permission only if its
-// embedder also has access. For certain APIs, such as the Dialog API,
-// additional information may be passed by the developer through |user_input|.
-IPC_MESSAGE_ROUTED4(BrowserPluginHostMsg_RespondPermission,
- int /* instance_id */,
- int /* request_id */,
- bool /* allow */,
- std::string /* user_input */)
-
// Sends a PointerLock Lock ACK to the BrowserPluginGuest.
IPC_MESSAGE_ROUTED2(BrowserPluginHostMsg_LockMouse_ACK,
int /* instance_id */,
@@ -363,14 +349,6 @@ IPC_MESSAGE_CONTROL5(BrowserPluginMsg_CompositorFrameSwapped,
uint32 /* output_surface_id */,
int /* renderer_host_id */)
-// When the guest requests permission, the browser process forwards this
-// request to the embeddder through this message.
-IPC_MESSAGE_CONTROL4(BrowserPluginMsg_RequestPermission,
- int /* instance_id */,
- BrowserPluginPermissionType /* permission_type */,
- int /* request_id */,
- base::DictionaryValue /* request_info */)
-
// Forwards a PointerLock Unlock request to the BrowserPlugin.
IPC_MESSAGE_CONTROL2(BrowserPluginMsg_SetMouseLock,
int /* instance_id */,

Powered by Google App Engine
This is Rietveld 408576698