<webview>: Refactor Permission API to chrome

chrome/browser/guestview/webview/webview_guest.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GUESTVIEW_WEBVIEW_WEBVIEW_GUEST_H_
 #define CHROME_BROWSER_GUESTVIEW_WEBVIEW_WEBVIEW_GUEST_H_
 
 #include "base/observer_list.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/guestview/guestview.h"
@@ skipping 32 matching lines @@
   virtual void AddMessageToConsole(int32 level,
                                    const string16& message,
                                    int32 line_no,
                                    const string16& source_id) OVERRIDE;
   virtual void Close() OVERRIDE;
   virtual void GuestProcessGone(base::TerminationStatus status) OVERRIDE;
   virtual bool HandleKeyboardEvent(
       const content::NativeWebKeyboardEvent& event) OVERRIDE;
   virtual void RendererResponsive() OVERRIDE;
   virtual void RendererUnresponsive() OVERRIDE;
+  virtual bool RequestPermission(
+      BrowserPluginPermissionType permission_type,
+      const base::DictionaryValue& request_info,
+      const PermissionResponseCallback& callback) OVERRIDE;
 
   // NotificationObserver implementation.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // If possible, navigate the guest to |relative_index| entries away from the
   // current navigation entry.
   void Go(int relative_index);
 
   // Reload the guest.
   void Reload();
 
+  // Responds to the permission request |request_id| with |should_allow| and
+  // |user_input|.

[lazyboy, 2013/08/05 09:26:58]

Also say what the return value is

[Fady Samuel, 2013/08/06 07:14:40]

Done.

+  bool SetPermission(int request_id,
+                     bool should_allow,
+                     const std::string& user_input);
+
   // Stop loading the guest.
   void Stop();
 
   // Kill the guest process.
   void Terminate();
 
   extensions::ScriptExecutor* script_executor() {
     return script_executor_.get();
   }
 
@@ skipping 38 matching lines @@
   void AddWebViewToExtensionRendererState();
   static void RemoveWebViewFromExtensionRendererState(
       content::WebContents* web_contents);
 
   ObserverList<extensions::TabHelper::ScriptExecutionObserver>
       script_observers_;
   scoped_ptr<extensions::ScriptExecutor> script_executor_;
 
   content::NotificationRegistrar notification_registrar_;
 
+  // A counter to generate a unique request id for a permission request.
+  // We only need the ids to be unique for a given WebViewGuest.
+  int next_permission_request_id_;
+
+  // A map to store the callback for a request keyed by the request's id.
+  typedef std::map<int, PermissionResponseCallback> RequestMap;
+  RequestMap pending_permission_requests_;
+
   DISALLOW_COPY_AND_ASSIGN(WebViewGuest);
 };
 
 #endif  // CHROME_BROWSER_GUESTVIEW_WEBVIEW_WEBVIEW_GUEST_H_