<webview>: Refactor Permission API to chrome

content/public/common/browser_plugin_message_enums.h

 // Copyright 2013 The Chromium Authors. All rights reserved.

[jam, 2013/08/09 00:07:27]

nit: rename this file to browser_plugin_permission_type.h

[Fady Samuel, 2013/08/09 15:52:58]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CONTENT_COMMON_BROWSER_PLUGIN_BROWSER_PLUGIN_MESSAGE_ENUMS_H_
-#define CONTENT_COMMON_BROWSER_PLUGIN_BROWSER_PLUGIN_MESSAGE_ENUMS_H_
+#ifndef CONTENT_COMMON_BROWSER_PLUGIN_MESSAGE_ENUMS_H_
+#define CONTENT_COMMON_BROWSER_PLUGIN_MESSAGE_ENUMS_H_
 
 enum BrowserPluginPermissionType {
   // Unknown type of permission request.
-  BrowserPluginPermissionTypeUnknown,
+  BROWSER_PLUGIN_PERMISSION_TYPE_UNKNOWN,
 
   // Download.

[jam, 2013/08/09 00:07:27]

nit: this, line 15, and line 21 should be taken out as they don't serve a
purpose

[Fady Samuel, 2013/08/09 15:52:58]

Done.

-  BrowserPluginPermissionTypeDownload,
+  BROWSER_PLUGIN_PERMISSION_TYPE_DOWNLOAD,
 
   // Geolocation.
-  BrowserPluginPermissionTypeGeolocation,
+  BROWSER_PLUGIN_PERMISSION_TYPE_GEOLOCATION,
 
   // Media access (audio/video) permission request type.
-  BrowserPluginPermissionTypeMedia,
+  BROWSER_PLUGIN_PERMISSION_TYPE_MEDIA,
 
   // PointerLock
-  BrowserPluginPermissionTypePointerLock,
+  BROWSER_PLUGIN_PERMISSION_TYPE_POINTER_LOCK,
 
 

[jam, 2013/08/09 00:07:27]

nit: extra line

[Fady Samuel, 2013/08/09 15:52:58]

Done.

   // New window requests.
   // Note: Even though new windows don't use the permission API, the new window
   // API is sufficiently similar that it's convenient to consider it a
   // permission type for code reuse.
-  BrowserPluginPermissionTypeNewWindow,
+  BROWSER_PLUGIN_PERMISSION_TYPE_NEW_WINDOW,
 
   // JavaScript Dialogs: prompt, alert, confirm
   // Note: Even through dialogs do not use the permission API, the dialog API
   // is sufficiently similiar that it's convenient to consider it a permission
   // type for code reuse.
-  BrowserPluginPermissionTypeJavaScriptDialog
+  BROWSER_PLUGIN_PERMISSION_TYPE_JAVASCRIPT_DIALOG
 };
 
-#endif  // CONTENT_COMMON_BROWSER_PLUGIN_BROWSER_PLUGIN_MESSAGE_ENUMS_H_
+#endif  // CONTENT_COMMON_BROWSER_PLUGIN_MESSAGE_ENUMS_H_