Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129653002: Revert of ppapi: PPB_VpnProvider: Implement Resource Host (Closed)

Created:
4 years, 5 months ago by brucedawson
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@vpn-nacl-sdk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ppapi: PPB_VpnProvider: Implement Resource Host (patchset #32 id:620001 of https://codereview.chromium.org/1735473002/ ) Reason for revert: Speculative revert to try to fix failing Android tests. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/28629 android_webview_test_apk on Android android_webview_test_apk on Android failed 22 failures: org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDouble with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextForward with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearMatches with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllFinds org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearFindNext org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllEmptyNext org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDoubleNext with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextForward org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBig org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBig with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDouble org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBackward org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearFindNext with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllDoubleNext org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllEmptyNext with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextFirst org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindEmptyNext org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextFirst with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindNextBackward with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindEmptyNext with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testFindAllFinds with {--webview-sandboxed-renderer} org.chromium.android_webview.test.WebViewAsynchronousFindApisTest#testClearMatches Original issue's description: > ppapi: PPB_VpnProvider: Implement Resource Host > > BUG=506490 > > Committed: https://crrev.com/8a1558d86fa478c65aba0b268129a9d8f2d3a7af > Cr-Commit-Position: refs/heads/master@{#403909} TBR=dcheng@chromium.org,bartfab@chromium.org,bbudge@chromium.org,dskaram@chromium.org,robert.bradford@intel.com,cernekee@chromium.org,emaxx@chromium.org,adrian.belgun@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506490 Committed: https://crrev.com/c2b444e09ff58537c4b5a61ac03d897b0c8be066 Cr-Commit-Position: refs/heads/master@{#403931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -523 lines) Patch
M content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc View 3 chunks +0 lines, -13 lines 0 comments Download
D content/browser/renderer_host/pepper/pepper_vpn_provider_message_filter_chromeos.h View 1 chunk +0 lines, -116 lines 0 comments Download
D content/browser/renderer_host/pepper/pepper_vpn_provider_message_filter_chromeos.cc View 1 chunk +0 lines, -314 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -27 lines 0 comments Download
M ppapi/proxy/vpn_provider_resource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/vpn_provider_resource.cc View 7 chunks +9 lines, -41 lines 0 comments Download
M ppapi/shared_impl/vpn_provider_util.h View 1 chunk +2 lines, -5 lines 0 comments Download
M ppapi/shared_impl/vpn_provider_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
Created Revert of ppapi: PPB_VpnProvider: Implement Resource Host
4 years, 5 months ago (2016-07-06 17:47:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129653002/1
4 years, 5 months ago (2016-07-06 17:48:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 17:49:21 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c2b444e09ff58537c4b5a61ac03d897b0c8be066 Cr-Commit-Position: refs/heads/master@{#403931}
4 years, 5 months ago (2016-07-06 17:51:07 UTC) #7
brucedawson
4 years, 5 months ago (2016-07-07 00:10:43 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2128743002/ by brucedawson@chromium.org.

The reason for reverting is: Relanding because the speculative revert did not
help the Android tests, the original CL is fine..

Powered by Google App Engine
This is Rietveld 408576698