Chromium Code Reviews

Issue 2129643002: PPC/s390: [builtins] Add receiver to builtin exit frames (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
Reviewers:
MTBrandyberry, michael_dawson, john.yan, JoranSiu, jgruber
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Add receiver to builtin exit frames Port f59a23356b437e369d75445177fea838ee5bccc7 Original commit message: Stack trace generation requires access to the receiver; and while the receiver is already on the stack, we cannot determine its position during stack trace generation (it's stored in argv[0], and argc is only stored in a callee-saved register). This patch grants access to the receiver by pushing argc onto builtin exit frames as an extra argument. Compared to simply pushing the receiver, this requires an additional dereference during stack trace generation, but one fewer during builtin calls. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4815 LOG=N Committed: https://crrev.com/96ebd75600f27873673bc3104e8af2c8b41932f5 Cr-Commit-Position: refs/heads/master@{#37563}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+12 lines, -7 lines)
M src/ppc/builtins-ppc.cc View 1 chunk +6 lines, -4 lines 0 comments
M src/s390/builtins-s390.cc View 1 chunk +6 lines, -3 lines 0 comments

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-07-06 17:42:29 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-06 17:43:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129643002/1
4 years, 5 months ago (2016-07-06 17:43:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 18:07:40 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:08:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96ebd75600f27873673bc3104e8af2c8b41932f5
Cr-Commit-Position: refs/heads/master@{#37563}

Powered by Google App Engine