Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2129563002: [ForIn] Fix HasEnumerableProperty for Proxies with null prototype (Closed)

Created:
4 years, 5 months ago by Jakob Kummerow
Modified:
4 years, 5 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ForIn] Fix HasEnumerableProperty for Proxies with null prototype BUG=v8:5181 Committed: https://crrev.com/b36237b8a38a84efb798cc5f16a100002711fd7a Cr-Commit-Position: refs/heads/master@{#37577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/runtime/runtime-forin.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-5181.js View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL.
4 years, 5 months ago (2016-07-06 14:55:05 UTC) #2
Camillo Bruni
lgtm
4 years, 5 months ago (2016-07-07 09:44:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129563002/1
4 years, 5 months ago (2016-07-07 09:45:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 10:09:59 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 10:12:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b36237b8a38a84efb798cc5f16a100002711fd7a
Cr-Commit-Position: refs/heads/master@{#37577}

Powered by Google App Engine
This is Rietveld 408576698