chrome/browser/about_flags.h - Issue 2129543002: Registering field trial for a feature overridden in chrome://flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.h

Issue 2129543002: Registering field trial for a feature overridden in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: After code review #1 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/about_flags.h

diff --git a/chrome/browser/about_flags.h b/chrome/browser/about_flags.h

index 91917421262c8a5540eed7331aeeca32dd94bc80..cbb42fcd157f5ed40f416262baf7472c7963c402 100644

--- a/chrome/browser/about_flags.h

+++ b/chrome/browser/about_flags.h

@@ -20,6 +20,7 @@

namespace base {

class ListValue;

+class FeatureList;

Lei Zhang 2016/07/13 17:49:02 nit: alphabetical order please

jkrcal 2016/07/14 08:45:12 Done.

}

namespace flags_ui {

@@ -37,7 +38,8 @@ void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage,

// Registers variations parameter values stored in |flags_storage| (previously

Lei Zhang 2016/07/13 17:49:02 Can you update the comment to mention |feature_lis

jkrcal 2016/07/14 08:45:12 Done.

// selected in about:flags).

void RegisterAllFeatureVariationParameters(

- flags_ui::FlagsStorage* flags_storage);

+ flags_ui::FlagsStorage* flags_storage,

+ base::FeatureList* feature_list);

// Compares a set of switches of the two provided command line objects and

// returns true if they are the same and false otherwise.

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | components/flags_ui/flags_state.h » ('J')