Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2651)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 2129543002: Registering field trial for a feature overridden in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 54df3f5641ce39e4442445d9eab7d90651824854..ce7c4fc86042a8eb24818e57962d51e8f3092419 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -723,12 +723,14 @@ void ChromeBrowserMainParts::SetupMetricsAndFieldTrials() {
metrics->AddSyntheticTrialObserver(provider);
}
+ std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
+
// Associate parameters chosen in about:flags and create trial/group for them.
flags_ui::PrefServiceFlagsStorage flags_storage(
g_browser_process->local_state());
- about_flags::RegisterAllFeatureVariationParameters(&flags_storage);
+ about_flags::RegisterAllFeatureVariationParameters(&flags_storage,
+ feature_list.get());
- std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
feature_list->InitializeFromCommandLine(
command_line->GetSwitchValueASCII(switches::kEnableFeatures),
command_line->GetSwitchValueASCII(switches::kDisableFeatures));

Powered by Google App Engine
This is Rietveld 408576698