Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2129533004: Revert of [esnext] ship --harmony-object-values-entries (Closed)

Created:
4 years, 5 months ago by Dan Ehrenberg
Modified:
4 years, 5 months ago
Reviewers:
caitp (gmail), adamk
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [esnext] ship --harmony-object-values-entries (patchset #1 id:1 of https://codereview.chromium.org/2116053003/ ) Reason for revert: Revert to see if it addresses the performance regression observed in chromium:625956 in automated graphs Original issue's description: > [esnext] ship --harmony-object-values-entries > > BUG=v8:4663 > R=littledan@chromium.org, adamk@chromium.org > > Committed: https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf > Cr-Commit-Position: refs/heads/master@{#37485} TBR=adamk@chromium.org,caitpotter88@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4663 Committed: https://crrev.com/1177750a98faaa11e92ece13b70115bf704baf3b Cr-Commit-Position: refs/heads/master@{#37566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/flag-definitions.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
Created Revert of [esnext] ship --harmony-object-values-entries
4 years, 5 months ago (2016-07-06 22:39:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2129533004/1
4 years, 5 months ago (2016-07-06 22:39:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 23:08:32 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1177750a98faaa11e92ece13b70115bf704baf3b Cr-Commit-Position: refs/heads/master@{#37566}
4 years, 5 months ago (2016-07-06 23:09:50 UTC) #6
Dan Ehrenberg
4 years, 5 months ago (2016-07-07 20:07:14 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2127253002/ by littledan@chromium.org.

The reason for reverting is: Performance stayed the same after the revert;
relanding..

Powered by Google App Engine
This is Rietveld 408576698