Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chromeos/network/favorite_state.cc

Issue 212953010: Revert of Always list EthernetEAP as a Favorite for debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/favorite_state.h ('k') | chromeos/network/managed_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/favorite_state.cc
diff --git a/chromeos/network/favorite_state.cc b/chromeos/network/favorite_state.cc
index 8ad9d3f9627648acb9c30dbe624e19f55370affd..5732fd83487f4f574121574413a0a8fa75f1ad53 100644
--- a/chromeos/network/favorite_state.cc
+++ b/chromeos/network/favorite_state.cc
@@ -83,13 +83,6 @@
return false;
}
-bool FavoriteState::IsFavorite() const {
- // kTypeEthernetEap is always a favorite. We need this check because it does
- // not show up in the visible list, but its properties may not be available
- // when it first shows up in ServiceCompleteList. See crbug.com/355117.
- return !profile_path_.empty() || type() == shill::kTypeEthernetEap;
-}
-
bool FavoriteState::IsPrivate() const {
return !profile_path_.empty() &&
profile_path_ != NetworkProfileHandler::GetSharedProfilePath();
« no previous file with comments | « chromeos/network/favorite_state.h ('k') | chromeos/network/managed_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698