Have SourceBuffer throw TypeError for non-finite doubles.

Have SourceBuffer throw TypeError for non-finite doubles.

Switch to throwing TypeError instead of TypeMismatchError when encountering
non-finite doubles, following what WebIDL requires

 http://heycam.github.io/webidl/#es-double

R=acolwell@chromium.org
BUG=353245
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170098

[sof, 2014-03-26 16:05:19]

Please take a look.

[acolwell GONE FROM CHROMIUM, 2014-03-26 16:41:35]

lgtm % nit

https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
File LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html
(right):

https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html:35:
assert_throws({name: "TypeError"},
nit: Why can't we just use "TypeError"? It seems odd we have to treat this error
special.

[sof, 2014-03-26 16:43:37]

https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
File LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html
(right):

https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html:35:
assert_throws({name: "TypeError"},
On 2014/03/26 16:41:36, acolwell wrote:
> nit: Why can't we just use "TypeError"? It seems odd we have to treat this
error
> special.

It'd be nice, but testharness.js only handles DOM exceptions via a string
argument to assert_throws().

[acolwell GONE FROM CHROMIUM, 2014-03-26 16:45:24]

On 2014/03/26 16:43:37, sof wrote:
>
https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
> File LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html
> (right):
> 
>
https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
> LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html:35:
> assert_throws({name: "TypeError"},
> On 2014/03/26 16:41:36, acolwell wrote:
> > nit: Why can't we just use "TypeError"? It seems odd we have to treat this
> error
> > special.
> 
> It'd be nice, but testharness.js only handles DOM exceptions via a string
> argument to assert_throws().
Ok. Should we supply a patch upstream to fix this?

[sof, 2014-03-26 16:50:52]

On 2014/03/26 16:45:24, acolwell wrote:
> On 2014/03/26 16:43:37, sof wrote:
> >
>
https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
> > File LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
> > LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html:35:
> > assert_throws({name: "TypeError"},
> > On 2014/03/26 16:41:36, acolwell wrote:
> > > nit: Why can't we just use "TypeError"? It seems odd we have to treat this
> > error
> > > special.
> > 
> > It'd be nice, but testharness.js only handles DOM exceptions via a string
> > argument to assert_throws().
> Ok. Should we supply a patch upstream to fix this?

assert_throws() supports what is documented to handle -- DOM exception testing,
with an extension mechanism via 'name' like here.

But better, more convenient testharness.js support for native errors/exceptions
would of course be worthwhile to work on.

[acolwell GONE FROM CHROMIUM, 2014-03-26 17:14:32]

On 2014/03/26 16:50:52, sof wrote:
> On 2014/03/26 16:45:24, acolwell wrote:
> > On 2014/03/26 16:43:37, sof wrote:
> > >
> >
>
https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
> > > File
LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html
> > > (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/212953004/diff/1/LayoutTests/http/tests/media...
> > >
LayoutTests/http/tests/media/media-source/mediasource-appendwindow.html:35:
> > > assert_throws({name: "TypeError"},
> > > On 2014/03/26 16:41:36, acolwell wrote:
> > > > nit: Why can't we just use "TypeError"? It seems odd we have to treat
this
> > > error
> > > > special.
> > > 
> > > It'd be nice, but testharness.js only handles DOM exceptions via a string
> > > argument to assert_throws().
> > Ok. Should we supply a patch upstream to fix this?
> 
> assert_throws() supports what is documented to handle -- DOM exception
testing,
> with an extension mechanism via 'name' like here.
> 
> But better, more convenient testharness.js support for native
errors/exceptions
> would of course be worthwhile to work on.

Ok. Thanks for the info. lgtm as is then.

[acolwell GONE FROM CHROMIUM, 2014-03-26 17:14:36]

The CQ bit was checked by acolwell@chromium.org

[commit-bot: I haz the power, 2014-03-26 17:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/212953004/1

[commit-bot: I haz the power, 2014-03-26 18:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 18:17:33]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[sof, 2014-03-26 18:32:17]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-26 18:32:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/212953004/1

[commit-bot: I haz the power, 2014-03-26 19:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 19:34:36]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[sof, 2014-03-26 19:59:09]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-26 19:59:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/212953004/1

[commit-bot: I haz the power, 2014-03-26 20:59:11]

Change committed as 170098

[sof, 2014-03-29 19:22:39]

On 2014/03/26 17:14:32, acolwell wrote:
> On 2014/03/26 16:50:52, sof wrote:
...
> > 
> > assert_throws() supports what is documented to handle -- DOM exception
> testing,
> > with an extension mechanism via 'name' like here.
> > 
> > But better, more convenient testharness.js support for native
> errors/exceptions
> > would of course be worthwhile to work on.
> 
> Ok. Thanks for the info. lgtm as is then.

Filed a feature request for simpler TypeError testing,
https://github.com/w3c/testharness.js/issues/62