TimelinePanel: provide scriptId in FunctionCall event.

Source/devtools/front_end/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 656 matching lines @@
 WebInspector.TimelineUIUtils._quadHeight = function(quad)
 {
     return Math.round(Math.sqrt(Math.pow(quad[0] - quad[6], 2) + Math.pow(quad[1] - quad[7], 2)));
 }
 
 /**
  * @param {!WebInspector.TimelineModel.Record} record
  * @param {!WebInspector.Linkifier} linkifier
  * @return {?Node}
  */
 WebInspector.TimelineUIUtils.buildDetailsNode = function(record, linkifier)

[pfeldman, 2014/04/01 14:24:33]

You should pass loadedFromFile as an input param instead.

 {
     var details;
     var detailsText;
+    var model = record.model();
 
     switch (record.type) {
     case WebInspector.TimelineModel.RecordType.GCEvent:
         detailsText = WebInspector.UIString("%s collected", Number.bytesToString(record.data["usedHeapSizeDelta"]));
         break;
     case WebInspector.TimelineModel.RecordType.TimerFire:
         detailsText = record.data["timerId"];
         break;
     case WebInspector.TimelineModel.RecordType.FunctionCall:
-        if (record.scriptName)
-            details = linkifyLocation(record.scriptName, record.scriptLine, 0);
+        details = linkifyLocation(record.scriptId, record.scriptName, record.scriptLine, 0);
         break;
     case WebInspector.TimelineModel.RecordType.FireAnimationFrame:
         detailsText = record.data["id"];
         break;
     case WebInspector.TimelineModel.RecordType.EventDispatch:
         detailsText = record.data ? record.data["type"] : null;
         break;
     case WebInspector.TimelineModel.RecordType.Paint:
         var width = record.data.clip ? WebInspector.TimelineUIUtils._quadWidth(record.data.clip) : record.data.width;
         var height = record.data.clip ? WebInspector.TimelineUIUtils._quadHeight(record.data.clip) : record.data.height;
         if (width && height)
             detailsText = WebInspector.UIString("%d\u2009\u00d7\u2009%d", width, height);
         break;
     case WebInspector.TimelineModel.RecordType.TimerInstall:
     case WebInspector.TimelineModel.RecordType.TimerRemove:
         details = linkifyTopCallFrame();
         detailsText = record.data["timerId"];
         break;
     case WebInspector.TimelineModel.RecordType.RequestAnimationFrame:
     case WebInspector.TimelineModel.RecordType.CancelAnimationFrame:
         details = linkifyTopCallFrame();
         detailsText = record.data["id"];
         break;
     case WebInspector.TimelineModel.RecordType.ParseHTML:
     case WebInspector.TimelineModel.RecordType.RecalculateStyles:
         details = linkifyTopCallFrame();
         break;
     case WebInspector.TimelineModel.RecordType.EvaluateScript:
-        details = record.url ? linkifyLocation(record.url, record.data["lineNumber"], 0) : null;
+        details = linkifyLocation("", record.url, record.data["lineNumber"], 0);
         break;
     case WebInspector.TimelineModel.RecordType.XHRReadyStateChange:
     case WebInspector.TimelineModel.RecordType.XHRLoad:
     case WebInspector.TimelineModel.RecordType.ScheduleResourceRequest:
     case WebInspector.TimelineModel.RecordType.ResourceSendRequest:
     case WebInspector.TimelineModel.RecordType.ResourceReceivedData:
     case WebInspector.TimelineModel.RecordType.ResourceReceiveResponse:
     case WebInspector.TimelineModel.RecordType.ResourceFinish:
     case WebInspector.TimelineModel.RecordType.DecodeImage:
     case WebInspector.TimelineModel.RecordType.ResizeImage:
         detailsText = WebInspector.displayNameForURL(record.url);
         break;
     case WebInspector.TimelineModel.RecordType.ConsoleTime:
         detailsText = record.data["message"];
         break;
     case WebInspector.TimelineModel.RecordType.EmbedderCallback:
         detailsText = record.data["callbackName"];
         break;
     default:
-        details = record.scriptName ? linkifyLocation(record.scriptName, record.scriptLine, 0) : linkifyTopCallFrame();
+        details = linkifyTopCallFrame();
         break;
     }
 
     if (!details && detailsText)
         details = document.createTextNode(detailsText);
     return details;
 
     /**
+     * @param {string} scriptId
      * @param {string} url
      * @param {number} lineNumber
      * @param {number=} columnNumber
      */
-    function linkifyLocation(url, lineNumber, columnNumber)
+    function linkifyLocation(scriptId, url, lineNumber, columnNumber)
     {
+        if (!model.loadedFromFile() && scriptId) {
+            var location = new WebInspector.DebuggerModel.Location(scriptId, lineNumber, columnNumber || 0);
+            return linkifier.linkifyRawLocation(location, "timeline-details");
+        }
+
+        if (!url)
+            return null;
+
         // FIXME(62725): stack trace line/column numbers are one-based.
         columnNumber = columnNumber ? columnNumber - 1 : 0;
         return linkifier.linkifyLocation(url, lineNumber - 1, columnNumber, "timeline-details");
     }
 
     /**
      * @param {!ConsoleAgent.CallFrame} callFrame
      */
     function linkifyCallFrame(callFrame)
     {
-        return linkifyLocation(callFrame.url, callFrame.lineNumber, callFrame.columnNumber);
+        return linkifyLocation(callFrame.scriptId, callFrame.url, callFrame.lineNumber, callFrame.columnNumber);
     }
 
     /**
      * @return {?Element}
      */
     function linkifyTopCallFrame()
     {
         if (record.stackTrace)
             return linkifyCallFrame(record.stackTrace[0]);
         if (record.callSiteStackTrace)
             return linkifyCallFrame(record.callSiteStackTrace[0]);
         return null;
     }
-
-    /**
-     * @return {?Element}
-     */
-    function linkifyScriptLocation()
-    {
-        return record.scriptName ? linkifyLocation(record.scriptName, record.scriptLine, 0) : null;
-    }
 }
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
  * @param {string} name
  * @param {string} title
  * @param {number} overviewStripGroupIndex
  * @param {string} borderColor
  * @param {string} backgroundColor
@@ skipping 167 matching lines @@
         for (var i = 0; i < stackTrace.length; ++i) {
             var stackFrame = stackTrace[i];
             var row = stackTraceElement.createChild("div");
             row.createTextChild(stackFrame.functionName || WebInspector.UIString("(anonymous function)"));
             row.createTextChild(" @ ");
             var urlElement = this._linkifier.linkifyLocation(stackFrame.url, stackFrame.lineNumber - 1);
             row.appendChild(urlElement);
         }
     }
 }