TimelinePanel: provide scriptId in FunctionCall event.

Source/devtools/front_end/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 671 matching lines @@
     switch (record.type) {
     case WebInspector.TimelineModel.RecordType.GCEvent:
         detailsText = WebInspector.UIString("%s collected", Number.bytesToString(record.data["usedHeapSizeDelta"]));
         break;
     case WebInspector.TimelineModel.RecordType.TimerFire:
         detailsText = record.data["timerId"];
         break;
     case WebInspector.TimelineModel.RecordType.FunctionCall:
         if (record.scriptName)
             details = linkifyLocation(record.scriptName, record.scriptLine, 0);
+        else if (record.scriptId)
+            details = linkifyRawLocation(record.scriptId, record.scriptLine, 0);
         break;
     case WebInspector.TimelineModel.RecordType.FireAnimationFrame:
         detailsText = record.data["id"];
         break;
     case WebInspector.TimelineModel.RecordType.EventDispatch:
         detailsText = record.data ? record.data["type"] : null;
         break;
     case WebInspector.TimelineModel.RecordType.Paint:
         var width = record.data.clip ? WebInspector.TimelineUIUtils._quadWidth(record.data.clip) : record.data.width;
         var height = record.data.clip ? WebInspector.TimelineUIUtils._quadHeight(record.data.clip) : record.data.height;
@@ skipping 28 matching lines @@
     case WebInspector.TimelineModel.RecordType.ResizeImage:
         detailsText = WebInspector.displayNameForURL(record.url);
         break;
     case WebInspector.TimelineModel.RecordType.ConsoleTime:
         detailsText = record.data["message"];
         break;
     case WebInspector.TimelineModel.RecordType.EmbedderCallback:
         detailsText = record.data["callbackName"];
         break;
     default:
-        details = record.scriptName ? linkifyLocation(record.scriptName, record.scriptLine, 0) : linkifyTopCallFrame();
+        if (record.scriptName)

[pfeldman, 2014/03/28 15:17:07]

1) Why is this default?
2) Generic record does not have scriptName
3) You should first use id, then fall back to name when linkifying call frames.

+            details = linkifyLocation(record.scriptName, record.scriptLine, 0);
+        else if (record.scriptId)
+            details = linkifyRawLocation(record.scriptId, record.scriptLine, 0);
+        else
+            details = linkifyTopCallFrame();
         break;
     }
 
     if (!details && detailsText)
         details = document.createTextNode(detailsText);
     return details;
 
+
+    /**
+     * @param {string} scriptId
+     * @param {number} lineNumber
+     * @param {number=} columnNumber
+     */
+    function linkifyRawLocation(scriptId, lineNumber, columnNumber)
+    {
+        var location = new WebInspector.DebuggerModel.Location(scriptId, lineNumber, columnNumber || 0);
+        return linkifier.linkifyRawLocation(location, "timeline-details");
+    }
+
     /**
      * @param {string} url
      * @param {number} lineNumber
      * @param {number=} columnNumber
      */
     function linkifyLocation(url, lineNumber, columnNumber)
     {
         // FIXME(62725): stack trace line/column numbers are one-based.
         columnNumber = columnNumber ? columnNumber - 1 : 0;
         return linkifier.linkifyLocation(url, lineNumber - 1, columnNumber, "timeline-details");
     }
 
     /**
      * @param {!ConsoleAgent.CallFrame} callFrame
      */
     function linkifyCallFrame(callFrame)
     {
         return linkifyLocation(callFrame.url, callFrame.lineNumber, callFrame.columnNumber);
     }
 
     /**
      * @return {?Element}
      */
     function linkifyTopCallFrame()
     {
         if (record.stackTrace)
             return linkifyCallFrame(record.stackTrace[0]);

[pfeldman, 2014/03/28 15:17:07]

Stacks should be using scriptIds as well.

         if (record.callSiteStackTrace)
             return linkifyCallFrame(record.callSiteStackTrace[0]);
         return null;
     }
 
     /**
      * @return {?Element}
      */
     function linkifyScriptLocation()
     {
@@ skipping 179 matching lines @@
         for (var i = 0; i < stackTrace.length; ++i) {
             var stackFrame = stackTrace[i];
             var row = stackTraceElement.createChild("div");
             row.createTextChild(stackFrame.functionName || WebInspector.UIString("(anonymous function)"));
             row.createTextChild(" @ ");
             var urlElement = this._linkifier.linkifyLocation(stackFrame.url, stackFrame.lineNumber - 1);
             row.appendChild(urlElement);
         }
     }
 }