Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212953003: TimelinePanel: provide scriptId in FunctionCall event. (Closed)

Created:
6 years, 9 months ago by loislo
Modified:
6 years, 8 months ago
Reviewers:
caseq, vsevik, aandrey, pfeldman
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, kouhei+bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

TimelinePanel: provide scriptId in FunctionCall event. otherwise these function calls will have no clickable url. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170651

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments addressed #

Patch Set 3 : minor change #

Total comments: 1

Patch Set 4 : rebaselined. test was added. comments addressed #

Patch Set 5 : minor change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -35 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-injected-script-eval-expected.txt View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A LayoutTests/inspector/timeline/timeline-script-id.html View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A LayoutTests/inspector/timeline/timeline-script-id-expected.txt View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-timer-expected.txt View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/TimelineRecordFactory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/TimelineRecordFactory.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/TimelineFlameChart.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TimelineModel.js View 1 5 chunks +23 lines, -2 lines 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TimelineUIUtils.js View 1 2 3 4 11 chunks +26 lines, -19 lines 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
loislo
6 years, 9 months ago (2014-03-26 15:06:10 UTC) #1
pfeldman
https://codereview.chromium.org/212953003/diff/1/Source/bindings/v8/ScriptController.cpp File Source/bindings/v8/ScriptController.cpp (right): https://codereview.chromium.org/212953003/diff/1/Source/bindings/v8/ScriptController.cpp#newcode168 Source/bindings/v8/ScriptController.cpp:168: cookie = InspectorInstrumentation::willCallFunction(context, function->ScriptId(), resourceName, lineNumber); Do we need ...
6 years, 9 months ago (2014-03-26 16:28:57 UTC) #2
aandrey
any bug report for this?
6 years, 9 months ago (2014-03-26 17:50:53 UTC) #3
aandrey
On 2014/03/26 17:50:53, aandrey wrote: > any bug report for this? will this fix https://code.google.com/p/chromium/issues/detail?id=356606 ...
6 years, 9 months ago (2014-03-26 17:53:28 UTC) #4
loislo
On 2014/03/26 16:28:57, pfeldman wrote: > https://codereview.chromium.org/212953003/diff/1/Source/bindings/v8/ScriptController.cpp > File Source/bindings/v8/ScriptController.cpp (right): > > https://codereview.chromium.org/212953003/diff/1/Source/bindings/v8/ScriptController.cpp#newcode168 > ...
6 years, 9 months ago (2014-03-26 20:12:03 UTC) #5
pfeldman
https://codereview.chromium.org/212953003/diff/1/Source/devtools/front_end/TimelineUIUtils.js File Source/devtools/front_end/TimelineUIUtils.js (right): https://codereview.chromium.org/212953003/diff/1/Source/devtools/front_end/TimelineUIUtils.js#newcode742 Source/devtools/front_end/TimelineUIUtils.js:742: if (record.scriptName) 1) Why is this default? 2) Generic ...
6 years, 9 months ago (2014-03-28 15:17:06 UTC) #6
loislo
On 2014/03/28 15:17:06, pfeldman wrote: > https://codereview.chromium.org/212953003/diff/1/Source/devtools/front_end/TimelineUIUtils.js > File Source/devtools/front_end/TimelineUIUtils.js (right): > > https://codereview.chromium.org/212953003/diff/1/Source/devtools/front_end/TimelineUIUtils.js#newcode742 > ...
6 years, 8 months ago (2014-04-01 13:40:45 UTC) #7
pfeldman
Could you add a test? https://codereview.chromium.org/212953003/diff/60001/Source/devtools/front_end/TimelineUIUtils.js File Source/devtools/front_end/TimelineUIUtils.js (right): https://codereview.chromium.org/212953003/diff/60001/Source/devtools/front_end/TimelineUIUtils.js#newcode677 Source/devtools/front_end/TimelineUIUtils.js:677: WebInspector.TimelineUIUtils.buildDetailsNode = function(record, linkifier) ...
6 years, 8 months ago (2014-04-01 14:24:32 UTC) #8
loislo
On 2014/04/01 14:24:32, pfeldman wrote: > Could you add a test? > > https://codereview.chromium.org/212953003/diff/60001/Source/devtools/front_end/TimelineUIUtils.js > ...
6 years, 8 months ago (2014-04-02 10:11:37 UTC) #9
pfeldman
lgtm
6 years, 8 months ago (2014-04-02 11:57:28 UTC) #10
loislo
6 years, 8 months ago (2014-04-02 12:07:07 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 manually as r170651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698